extensions/common/permissions/permissions_info.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permissions_info.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/permissions/permissions_info.cc

diff --git a/extensions/common/permissions/permissions_info.cc b/extensions/common/permissions/permissions_info.cc

index ad64fd5cb01edad4d9d5053305faa4cf47797d88..e83fb2e3a78bc70de0b391bdbe274e30984562e0 100644

--- a/extensions/common/permissions/permissions_info.cc

+++ b/extensions/common/permissions/permissions_info.cc

@@ -64,7 +64,7 @@ APIPermissionSet PermissionsInfo::GetAllByName(

bool PermissionsInfo::HasChildPermissions(const std::string& name) const {

NameMap::const_iterator i = name_map_.lower_bound(name + '.');

if (i == name_map_.end()) return false;

- return base::StartsWithASCII(i->first, name + '.', true);

+ return base::StartsWith(i->first, name + '.', base::CompareCase::SENSITIVE);

}

PermissionsInfo::PermissionsInfo()