third_party/zlib/google/zip_reader.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/zlib/google/zip_reader.cc

diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc

index e0871c85367321c785c31383f8cf8d2a28000027..83086a3467fb0e21201edf36aaa80a8908ab839b 100644

--- a/third_party/zlib/google/zip_reader.cc

+++ b/third_party/zlib/google/zip_reader.cc

@@ -147,7 +147,8 @@ ZipReader::EntryInfo::EntryInfo(const std::string& file_name_in_zip,

// We also consider that the file name is unsafe, if it's absolute.

// On Windows, IsAbsolute() returns false for paths starting with "/".

if (file_path_.IsAbsolute() ||

- base::StartsWithASCII(file_name_in_zip, "/", false))

+ base::StartsWith(file_name_in_zip, "/",

+ base::CompareCase::INSENSITIVE_ASCII))

is_unsafe_ = true;

// Construct the last modified time. The timezone info is not present in

« no previous file with comments | « storage/browser/fileapi/sandbox_origin_database.cc ('k') | tools/gn/filesystem_utils.cc » ('j') | no next file with comments »