Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: extensions/common/extension.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: y Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/csp_validator.cc ('k') | extensions/common/permissions/permissions_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension.cc
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc
index d42fce6a94918c42c005446c24fb9c9921e7ed99..b6803857ef917a2aacf79637f471ed28957358dc 100644
--- a/extensions/common/extension.cc
+++ b/extensions/common/extension.cc
@@ -154,7 +154,8 @@ GURL Extension::GetResourceURL(const GURL& extension_url,
path = relative_path.substr(1);
GURL ret_val = GURL(extension_url.spec() + path);
- DCHECK(base::StartsWithASCII(ret_val.spec(), extension_url.spec(), false));
+ DCHECK(base::StartsWith(ret_val.spec(), extension_url.spec(),
+ base::CompareCase::INSENSITIVE_ASCII));
return ret_val;
}
@@ -205,7 +206,8 @@ bool Extension::ParsePEMKeyBytes(const std::string& input,
return false;
std::string working = input;
- if (base::StartsWithASCII(working, kKeyBeginHeaderMarker, true)) {
+ if (base::StartsWith(working, kKeyBeginHeaderMarker,
+ base::CompareCase::SENSITIVE)) {
working = base::CollapseWhitespaceASCII(working, true);
size_t header_pos = working.find(kKeyInfoEndMarker,
sizeof(kKeyBeginHeaderMarker) - 1);
« no previous file with comments | « extensions/common/csp_validator.cc ('k') | extensions/common/permissions/permissions_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698