extensions/browser/api/cast_channel/logger.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/logger.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/logger.cc

diff --git a/extensions/browser/api/cast_channel/logger.cc b/extensions/browser/api/cast_channel/logger.cc

index 38d8e6180991b2abae55de812b0b6ccc67345c5b..9eb80dbb472a3a10b02e29a24465b9fce948e22d 100644

--- a/extensions/browser/api/cast_channel/logger.cc

+++ b/extensions/browser/api/cast_channel/logger.cc

@@ -251,7 +251,8 @@ void Logger::LogSocketEventForMessage(int channel_id,

DCHECK(thread_checker_.CalledOnValidThread());

SocketEvent event = CreateEvent(event_type);

- if (base::StartsWithASCII(message_namespace, kInternalNamespacePrefix, false))

+ if (base::StartsWith(message_namespace, kInternalNamespacePrefix,

+ base::CompareCase::INSENSITIVE_ASCII))

event.set_message_namespace(message_namespace);

event.set_details(details);