Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: rlz/lib/rlz_lib.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: y Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/me2me_host_authenticator_factory.cc ('k') | rlz/win/lib/machine_deal.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/lib/rlz_lib.cc
diff --git a/rlz/lib/rlz_lib.cc b/rlz/lib/rlz_lib.cc
index 4a3cfdeaa424495bad641ca90f6f134c4ef7b5f0..c5403f6e4b564753dcd5990d5f84d0cba0d525a4 100644
--- a/rlz/lib/rlz_lib.cc
+++ b/rlz/lib/rlz_lib.cc
@@ -422,7 +422,8 @@ bool IsPingResponseValid(const char* response, int* checksum_idx) {
return false;
} else {
checksum_param = "crc32: "; // Empty response case.
- if (!base::StartsWithASCII(response_string, checksum_param, true))
+ if (!base::StartsWith(response_string, checksum_param,
+ base::CompareCase::SENSITIVE))
return false;
checksum_index = 0;
@@ -534,8 +535,8 @@ bool ParsePingResponse(Product product, const char* response) {
std::string response_line;
response_line = response_string.substr(line_begin, line_end - line_begin);
- if (base::StartsWithASCII(response_line, kRlzCgiVariable,
- true)) { // An RLZ.
+ if (base::StartsWith(response_line, kRlzCgiVariable,
+ base::CompareCase::SENSITIVE)) { // An RLZ.
int separator_index = -1;
if ((separator_index = response_line.find(": ")) < 0)
continue; // Not a valid key-value pair.
@@ -561,7 +562,8 @@ bool ParsePingResponse(Product product, const char* response) {
if (IsAccessPointSupported(point))
SetAccessPointRlz(point, rlz_value.substr(0, rlz_length).c_str());
- } else if (base::StartsWithASCII(response_line, events_variable, true)) {
+ } else if (base::StartsWith(response_line, events_variable,
+ base::CompareCase::SENSITIVE)) {
// Clear events which server parsed.
std::vector<ReturnedEvent> event_array;
GetEventsFromResponseString(response_line, events_variable, &event_array);
@@ -569,8 +571,8 @@ bool ParsePingResponse(Product product, const char* response) {
ClearProductEvent(product, event_array[i].access_point,
event_array[i].event_type);
}
- } else if (base::StartsWithASCII(response_line, stateful_events_variable,
- true)) {
+ } else if (base::StartsWith(response_line, stateful_events_variable,
+ base::CompareCase::SENSITIVE)) {
// Record any stateful events the server send over.
std::vector<ReturnedEvent> event_array;
GetEventsFromResponseString(response_line, stateful_events_variable,
« no previous file with comments | « remoting/protocol/me2me_host_authenticator_factory.cc ('k') | rlz/win/lib/machine_deal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698