Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chromeos/dbus/session_manager_client.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: y Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/disks/disk_mount_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/session_manager_client.h" 5 #include "chromeos/dbus/session_manager_client.h"
6 6
7 #include <sys/socket.h> 7 #include <sys/socket.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 } 558 }
559 559
560 // Called when the owner key set signal is received. 560 // Called when the owner key set signal is received.
561 void OwnerKeySetReceived(dbus::Signal* signal) { 561 void OwnerKeySetReceived(dbus::Signal* signal) {
562 dbus::MessageReader reader(signal); 562 dbus::MessageReader reader(signal);
563 std::string result_string; 563 std::string result_string;
564 if (!reader.PopString(&result_string)) { 564 if (!reader.PopString(&result_string)) {
565 LOG(ERROR) << "Invalid signal: " << signal->ToString(); 565 LOG(ERROR) << "Invalid signal: " << signal->ToString();
566 return; 566 return;
567 } 567 }
568 const bool success = base::StartsWithASCII(result_string, "success", false); 568 const bool success = base::StartsWith(result_string, "success",
569 base::CompareCase::INSENSITIVE_ASCII);
569 FOR_EACH_OBSERVER(Observer, observers_, OwnerKeySet(success)); 570 FOR_EACH_OBSERVER(Observer, observers_, OwnerKeySet(success));
570 } 571 }
571 572
572 // Called when the property change complete signal is received. 573 // Called when the property change complete signal is received.
573 void PropertyChangeCompleteReceived(dbus::Signal* signal) { 574 void PropertyChangeCompleteReceived(dbus::Signal* signal) {
574 dbus::MessageReader reader(signal); 575 dbus::MessageReader reader(signal);
575 std::string result_string; 576 std::string result_string;
576 if (!reader.PopString(&result_string)) { 577 if (!reader.PopString(&result_string)) {
577 LOG(ERROR) << "Invalid signal: " << signal->ToString(); 578 LOG(ERROR) << "Invalid signal: " << signal->ToString();
578 return; 579 return;
579 } 580 }
580 const bool success = base::StartsWithASCII(result_string, "success", false); 581 const bool success = base::StartsWith(result_string, "success",
582 base::CompareCase::INSENSITIVE_ASCII);
581 FOR_EACH_OBSERVER(Observer, observers_, PropertyChangeComplete(success)); 583 FOR_EACH_OBSERVER(Observer, observers_, PropertyChangeComplete(success));
582 } 584 }
583 585
584 void ScreenIsLockedReceived(dbus::Signal* signal) { 586 void ScreenIsLockedReceived(dbus::Signal* signal) {
585 screen_is_locked_ = true; 587 screen_is_locked_ = true;
586 FOR_EACH_OBSERVER(Observer, observers_, ScreenIsLocked()); 588 FOR_EACH_OBSERVER(Observer, observers_, ScreenIsLocked());
587 } 589 }
588 590
589 void ScreenIsUnlockedReceived(dbus::Signal* signal) { 591 void ScreenIsUnlockedReceived(dbus::Signal* signal) {
590 screen_is_locked_ = false; 592 screen_is_locked_ = false;
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 815
814 SessionManagerClient* SessionManagerClient::Create( 816 SessionManagerClient* SessionManagerClient::Create(
815 DBusClientImplementationType type) { 817 DBusClientImplementationType type) {
816 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION) 818 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
817 return new SessionManagerClientImpl(); 819 return new SessionManagerClientImpl();
818 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type); 820 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
819 return new SessionManagerClientStubImpl(); 821 return new SessionManagerClientStubImpl();
820 } 822 }
821 823
822 } // namespace chromeos 824 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/disks/disk_mount_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698