google_apis/gcm/engine/gcm_store_impl.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/gcm_store_impl.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/engine/gcm_store_impl.cc

diff --git a/google_apis/gcm/engine/gcm_store_impl.cc b/google_apis/gcm/engine/gcm_store_impl.cc

index a4cbfe229b5df447ebc37c185c4b9085bf593769..8ac2521028ec444ee9a82919cc9f83156492b621 100644

--- a/google_apis/gcm/engine/gcm_store_impl.cc

+++ b/google_apis/gcm/engine/gcm_store_impl.cc

@@ -357,7 +357,8 @@ void GCMStoreImpl::Backend::Load(StoreOpenMode open_mode,

int gcm_registration_count = 0;

int instance_id_token_count = 0;

for (const auto& registration : result->registrations) {

- if (base::StartsWithASCII(registration.first, "iid-", true))

+ if (base::StartsWith(registration.first, "iid-",

+ base::CompareCase::SENSITIVE))

instance_id_token_count++;

else

gcm_registration_count++;