components/google/core/browser/google_url_tracker.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/google/core/browser/google_url_tracker.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/google/core/browser/google_url_tracker.cc

diff --git a/components/google/core/browser/google_url_tracker.cc b/components/google/core/browser/google_url_tracker.cc

index 770c9af48bd3d0625bb667ae499fd7e301155a02..2ead3643b3d199f29fef070df9d7c0abcfb9a9a4 100644

--- a/components/google/core/browser/google_url_tracker.cc

+++ b/components/google/core/browser/google_url_tracker.cc

@@ -97,7 +97,8 @@ void GoogleURLTracker::OnURLFetchComplete(const net::URLFetcher* source) {

std::string url_str;

source->GetResponseAsString(&url_str);

base::TrimWhitespace(url_str, base::TRIM_ALL, &url_str);

- if (!base::StartsWithASCII(url_str, ".google.", false))

+ if (!base::StartsWith(url_str, ".google.",

+ base::CompareCase::INSENSITIVE_ASCII))

return;

GURL url("https://www" + url_str);

if (!url.is_valid() || (url.path().length() > 1) || url.has_query() ||