storage/browser/blob/blob_url_request_job_factory.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_url_request_job_factory.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/blob/blob_url_request_job_factory.cc

diff --git a/storage/browser/blob/blob_url_request_job_factory.cc b/storage/browser/blob/blob_url_request_job_factory.cc

index 7efe2807ff0bef48e043fa7950c0731438877295..feb5df0855ca50dad00c039a049f28b3b9632f84 100644

--- a/storage/browser/blob/blob_url_request_job_factory.cc

+++ b/storage/browser/blob/blob_url_request_job_factory.cc

@@ -78,7 +78,8 @@ scoped_ptr<BlobDataSnapshot> BlobProtocolHandler::LookupBlobData(

// TODO(michaeln): Replace this use case and others like it with a BlobReader

// impl that does not depend on urlfetching to perform this function.

const std::string kPrefix("blob:uuid/");

- if (!base::StartsWithASCII(request->url().spec(), kPrefix, true))

+ if (!base::StartsWith(request->url().spec(), kPrefix,

+ base::CompareCase::SENSITIVE))

return NULL;

std::string uuid = request->url().spec().substr(kPrefix.length());

scoped_ptr<BlobDataHandle> handle = context_->GetBlobDataFromUUID(uuid);