components/favicon/core/favicon_driver_impl.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_driver_impl.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_driver_impl.cc

diff --git a/components/favicon/core/favicon_driver_impl.cc b/components/favicon/core/favicon_driver_impl.cc

index 90075698f15cc649cb276a3795efa7d3d5027b9f..bd22f7b30ff8f1473e57c00c0bc3511ac6298399 100644

--- a/components/favicon/core/favicon_driver_impl.cc

+++ b/components/favicon/core/favicon_driver_impl.cc

@@ -30,7 +30,7 @@ bool IsIconNTPEnabled() {

if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableIconNtp))

return true;

- return base::StartsWithASCII(group_name, "Enabled", true);

+ return base::StartsWith(group_name, "Enabled", base::CompareCase::SENSITIVE);

}

#if defined(OS_ANDROID) || defined(OS_IOS)