Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: content/public/test/test_launcher.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: y Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | content/renderer/savable_resources.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_launcher.cc
diff --git a/content/public/test/test_launcher.cc b/content/public/test/test_launcher.cc
index 187de3efc85d64d348e71eb9cb6324857e5883cf..596a1252479105eff78ef6235aa5d705575e54d4 100644
--- a/content/public/test/test_launcher.cc
+++ b/content/public/test/test_launcher.cc
@@ -183,12 +183,14 @@ bool WrapperTestLauncherDelegate::ShouldRunTest(
const std::string& test_name) {
all_test_names_.insert(test_case_name + "." + test_name);
- if (base::StartsWithASCII(test_name, kManualTestPrefix, true) &&
+ if (base::StartsWith(test_name, kManualTestPrefix,
+ base::CompareCase::SENSITIVE) &&
!base::CommandLine::ForCurrentProcess()->HasSwitch(kRunManualTestsFlag)) {
return false;
}
- if (base::StartsWithASCII(test_name, kPreTestPrefix, true)) {
+ if (base::StartsWith(test_name, kPreTestPrefix,
+ base::CompareCase::SENSITIVE)) {
// We will actually run PRE_ tests, but to ensure they run on the same shard
// as dependent tests, handle all these details internally.
return false;
« no previous file with comments | « content/public/test/browser_test_utils.cc ('k') | content/renderer/savable_resources.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698