tools/gn/input_conversion.cc - Issue 1242023005: Remove legacy StartsWithASCII function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/input_conversion.cc

Issue 1242023005: Remove legacy StartsWithASCII function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: y Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/input_conversion.cc

diff --git a/tools/gn/input_conversion.cc b/tools/gn/input_conversion.cc

index e4c20a0988a4eb344b6ef39c6bd765e654737281..fbde6f68d0b758d0a6d324fb553eec04f1730582 100644

--- a/tools/gn/input_conversion.cc

+++ b/tools/gn/input_conversion.cc

@@ -116,7 +116,8 @@ Value DoConvertInputToValue(const Settings* settings,

return Value(); // Empty string means discard the result.

const char kTrimPrefix[] = "trim ";

- if (base::StartsWithASCII(input_conversion, kTrimPrefix, true)) {

+ if (base::StartsWith(input_conversion, kTrimPrefix,

+ base::CompareCase::SENSITIVE)) {

std::string trimmed;

base::TrimWhitespaceASCII(input, base::TRIM_ALL, &trimmed);

« no previous file with comments | « tools/gn/header_checker.cc ('k') | tools/gn/target.cc » ('j') | no next file with comments »