Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1113173003: Web Animations: Update naming to reflect spec changes (Closed)

Created:
5 years, 7 months ago by dstockwell
Modified:
5 years, 7 months ago
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, caseq+blink_chromium.org, Inactive, devtools-reviews_chromium.org, dstockwell, Eric Willigers, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, rjwright, sergeyv+blink_chromium.org, shans, Steve Block, Timothy Loh, vivekg_samsung, vivekg, yurys+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Update naming to reflect spec changes KeyframeEffect -> KeyframeEffectModel (internal) Animation -> KeyframeEffect AnimationEffect -> EffectModel AnimationNode -> AnimationEffect (internal), AnimationEffectReadOnly (idl) AnimationPlayer -> Animation Timing (internal), AnimationNodeTiming (idl), -> AnimationEffectTiming Note, this does not rename: * the WebCompositor* interfaces (for @loyso) * or the devtools protocol (for @samli) Follow on changes: * remove EffectModel from idl, to be replaced by SharedKeyframeList * rename InertAnimation to InertEffect * expose other *ReadOnly interfaces and add support for treating AnimationEffect as a read only instance BUG=483272 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194961

Patch Set 1 #

Patch Set 2 : Rename Animation to KeyframeEffect #

Patch Set 3 : Rename AnimationPlayer to Animation. #

Patch Set 4 : Fix erroneous renames. #

Patch Set 5 : Fix erroneous renames #

Patch Set 6 : Rename player to animation. #

Patch Set 7 : Rename AnimationEffect to EffectModel and AnimationNode to AnimationEffect #

Patch Set 8 : Clean up IDL and sort includes #

Patch Set 9 : Rebase #

Patch Set 10 : Use new API in layout tests #

Total comments: 42

Patch Set 11 : Address review comments #

Patch Set 12 : Rebase #

Patch Set 13 : Rebase. #

Patch Set 14 : REBASE #

Patch Set 15 : GAH #

Patch Set 16 : No, really. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3254 lines, -5627 lines) Patch
M LayoutTests/animations/resources/animation-test-helpers.js View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/transitions/interrupted-immediately.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/transitions/repeated-firing-background-color.html View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/transitions/transition-currentcolor.html View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/transitions/webkit-clip-path-equality.html View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/web-animations-api-expected.txt View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/web-animations-api/animation-constructor.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +16 lines, -16 lines 0 comments Download
M LayoutTests/web-animations-api/partial-keyframes.html View 1 2 3 4 5 6 7 8 9 7 chunks +23 lines, -23 lines 0 comments Download
M LayoutTests/web-animations-api/timed-item.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +41 lines, -41 lines 0 comments Download
M LayoutTests/web-animations-api/timed-item-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/web-animations-api/timed-item-specified-getters.html View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/web-animations-api/timed-item-specified-setters.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/web-animations-api/timeline-play-animation.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/web-animations-api/timeline-updates-players.html View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/web-animations-api/transitions-replay.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/web-animations-api/w3c/get-animation-players.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +80 lines, -80 lines 0 comments Download
M LayoutTests/web-animations-api/w3c/get-css-players.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +27 lines, -27 lines 0 comments Download
M LayoutTests/webexposed/web-animations-api.html View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/web-animations-api-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/animation/Animation.h View 1 2 3 4 5 6 1 chunk +217 lines, -52 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 2 3 4 5 6 1 chunk +892 lines, -201 lines 0 comments Download
M Source/core/animation/Animation.idl View 1 2 3 4 5 6 1 chunk +21 lines, -11 lines 0 comments Download
M Source/core/animation/AnimationEffect.h View 1 2 3 4 5 6 1 chunk +117 lines, -12 lines 0 comments Download
A + Source/core/animation/AnimationEffect.cpp View 1 2 3 4 5 6 7 8 9 11 chunks +29 lines, -29 lines 0 comments Download
D Source/core/animation/AnimationEffect.idl View 1 2 3 4 5 6 1 chunk +0 lines, -15 lines 0 comments Download
A + Source/core/animation/AnimationEffectReadOnly.idl View 1 2 3 4 5 6 1 chunk +3 lines, -6 lines 0 comments Download
A + Source/core/animation/AnimationEffectTest.cpp View 1 2 3 4 5 6 43 chunks +91 lines, -90 lines 0 comments Download
A + Source/core/animation/AnimationEffectTiming.h View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/animation/AnimationEffectTiming.cpp View 1 2 3 4 5 6 3 chunks +25 lines, -25 lines 0 comments Download
A + Source/core/animation/AnimationEffectTiming.idl View 1 2 3 4 5 6 7 1 chunk +4 lines, -7 lines 0 comments Download
D Source/core/animation/AnimationNode.h View 1 chunk +0 lines, -172 lines 0 comments Download
D Source/core/animation/AnimationNode.cpp View 1 chunk +0 lines, -236 lines 0 comments Download
D Source/core/animation/AnimationNode.idl View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/animation/AnimationNodeTest.cpp View 1 chunk +0 lines, -786 lines 0 comments Download
D Source/core/animation/AnimationNodeTiming.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/animation/AnimationNodeTiming.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 2 1 chunk +0 lines, -288 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 1 chunk +0 lines, -1032 lines 0 comments Download
M Source/core/animation/AnimationPlayer.idl View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 1 2 1 chunk +0 lines, -882 lines 0 comments Download
M Source/core/animation/AnimationStack.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/animation/AnimationStack.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +9 lines, -11 lines 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +28 lines, -28 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +747 lines, -329 lines 0 comments Download
M Source/core/animation/AnimationTimeline.h View 1 2 3 4 5 6 5 chunks +15 lines, -15 lines 0 comments Download
M Source/core/animation/AnimationTimeline.cpp View 1 2 3 4 5 6 8 chunks +49 lines, -49 lines 0 comments Download
M Source/core/animation/AnimationTimeline.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationTimelineTest.cpp View 1 2 3 4 5 6 7 8 9 10 6 chunks +22 lines, -22 lines 0 comments Download
D Source/core/animation/AnimationTimingProperties.idl View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/animation/CompositorAnimations.h View 1 2 3 4 5 6 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 1 2 3 4 5 6 19 chunks +55 lines, -55 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 1 2 3 4 5 6 7 8 9 10 21 chunks +57 lines, -57 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/CompositorPendingAnimations.cpp View 1 2 3 4 5 6 chunks +32 lines, -32 lines 0 comments Download
M Source/core/animation/ComputedTimingProperties.idl View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DocumentAnimations.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/DocumentAnimations.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/EffectInput.h View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/animation/EffectInput.cpp View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/animation/EffectModel.h View 1 2 3 4 5 6 4 chunks +6 lines, -6 lines 0 comments Download
A + Source/core/animation/EffectModel.idl View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/ElementAnimation.h View 1 2 3 4 5 6 7 8 9 2 chunks +18 lines, -18 lines 0 comments Download
M Source/core/animation/ElementAnimation.idl View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/animation/ElementAnimations.h View 1 2 3 4 5 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/ElementAnimations.cpp View 1 2 3 4 5 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/animation/InertAnimation.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/animation/InertAnimation.cpp View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/Keyframe.h View 1 2 3 4 5 6 7 6 chunks +9 lines, -9 lines 0 comments Download
A + Source/core/animation/KeyframeEffect.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +21 lines, -21 lines 0 comments Download
A + Source/core/animation/KeyframeEffect.cpp View 1 2 3 4 5 6 7 8 9 11 chunks +64 lines, -64 lines 0 comments Download
A + Source/core/animation/KeyframeEffect.idl View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -7 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 2 3 4 5 6 7 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 2 3 4 5 6 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 1 2 3 4 5 6 12 chunks +21 lines, -21 lines 0 comments Download
A + Source/core/animation/KeyframeEffectOptions.idl View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/animation/KeyframeEffectTest.cpp View 1 2 3 4 5 6 7 8 9 21 chunks +59 lines, -59 lines 0 comments Download
M Source/core/animation/SampledEffect.h View 1 2 3 4 5 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/SampledEffect.cpp View 1 2 3 4 5 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/animation/StringKeyframe.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 4 5 6 7 8 4 chunks +6 lines, -6 lines 0 comments Download
D Source/core/animation/Timing.idl View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/core/animation/TimingCalculations.h View 1 2 3 4 5 6 3 chunks +15 lines, -15 lines 0 comments Download
M Source/core/animation/TimingCalculationsTest.cpp View 1 2 3 4 5 6 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/animation/TimingInput.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/TimingInput.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/TimingInputTest.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/css/CSSAnimationUpdate.h View 1 2 3 4 5 6 7 8 9 10 11 12 12 chunks +34 lines, -34 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 2 3 4 5 6 7 chunks +21 lines, -21 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 20 chunks +86 lines, -86 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +19 lines, -19 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +15 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 1 2 3 4 5 6 7 8 14 chunks +35 lines, -35 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/style/KeyframeList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (15 generated)
dstockwell
5 years, 7 months ago (2015-05-04 07:05:44 UTC) #2
alancutter (OOO until 2018)
https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js File LayoutTests/animations/resources/animation-test-helpers.js (right): https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js#newcode208 LayoutTests/animations/resources/animation-test-helpers.js:208: log('Pausing at time: ' + timeMs + ', current ...
5 years, 7 months ago (2015-05-05 01:04:52 UTC) #3
dstockwell
https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js File LayoutTests/animations/resources/animation-test-helpers.js (right): https://codereview.chromium.org/1113173003/diff/170001/LayoutTests/animations/resources/animation-test-helpers.js#newcode208 LayoutTests/animations/resources/animation-test-helpers.js:208: log('Pausing at time: ' + timeMs + ', current ...
5 years, 7 months ago (2015-05-05 03:33:26 UTC) #4
alancutter (OOO until 2018)
rslgtm
5 years, 7 months ago (2015-05-05 04:07:01 UTC) #5
alancutter (OOO until 2018)
On 2015/05/05 at 04:07:01, alancutter wrote: > rslgtm rs=lgtm
5 years, 7 months ago (2015-05-05 04:07:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113173003/200106
5 years, 7 months ago (2015-05-05 09:09:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/54378)
5 years, 7 months ago (2015-05-05 09:14:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113173003/220001
5 years, 7 months ago (2015-05-06 00:16:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113173003/240001
5 years, 7 months ago (2015-05-06 00:41:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/builds/7935)
5 years, 7 months ago (2015-05-06 00:58:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113173003/260001
5 years, 7 months ago (2015-05-06 01:22:03 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43928)
5 years, 7 months ago (2015-05-06 01:36:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113173003/280001
5 years, 7 months ago (2015-05-06 03:16:56 UTC) #27
commit-bot: I haz the power
Committed patchset #16 (id:280001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194961
5 years, 7 months ago (2015-05-06 04:49:56 UTC) #28
caseq
5 years, 7 months ago (2015-05-18 19:58:37 UTC) #30
Message was sent while issue was closed. 
> Note, this does not rename:
[...]
> * or the devtools protocol (for @samli)

FWIW, it actually does, as it renamed a trace event  (Animation ->
KeyframeEffect). Not a big deal, as it wasn't actually used in front-end (yet),
but in general, if the trace event has devtools.timeline category, please be
aware that the name matters as it is likely used by DevTools front-end.

Powered by Google App Engine
This is Rietveld 408576698