Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: Source/core/animation/KeyframeEffect.idl

Issue 1113173003: Web Animations: Update naming to reflect spec changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: No, really. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/KeyframeEffect.cpp ('k') | Source/core/animation/KeyframeEffectModel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/KeyframeEffect.idl
diff --git a/Source/core/animation/Animation.idl b/Source/core/animation/KeyframeEffect.idl
similarity index 84%
copy from Source/core/animation/Animation.idl
copy to Source/core/animation/KeyframeEffect.idl
index 2da00b3bac00cb93fe8f2ab90e9bb0660c6eb868..0235507d149325283a9c79cc9ffcae328af77641 100644
--- a/Source/core/animation/Animation.idl
+++ b/Source/core/animation/KeyframeEffect.idl
@@ -28,18 +28,14 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// http://www.w3.org/TR/web-animations/#the-animation-interface
-
-// TODO(dstockwell): This interface has been renamed to KeyframeEffect in the
-// latest spec:
// https://w3c.github.io/web-animations/#the-keyframeeffect-interfaces
[
- // FIXME: the third argument should be "optional (unrestricted double or AnimationTimingProperties) timing".
+ // TODO(dstockwell): the third argument should be "optional (unrestricted double or KeyframeEffectOptions) timing".
Constructor(Element? target, sequence<Dictionary> keyframes, optional unrestricted double timing),
- Constructor(Element? target, sequence<Dictionary> keyframes, AnimationTimingProperties timing),
+ Constructor(Element? target, sequence<Dictionary> keyframes, KeyframeEffectOptions timing),
RaisesException=Constructor,
RuntimeEnabled=WebAnimationsAPI,
TypeChecking=Interface,
-] interface Animation : AnimationNode {
+] interface KeyframeEffect : AnimationEffectReadOnly {
};
« no previous file with comments | « Source/core/animation/KeyframeEffect.cpp ('k') | Source/core/animation/KeyframeEffectModel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698