Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 7649006: more changes (Closed)

Created:
9 years, 4 months ago by tfarina
Modified:
9 years, 4 months ago
Reviewers:
CC:
tfarina
Visibility:
Public.

Description

more changes incremental changes, public explicit ctors base: Split FundamentalValue into its values. This patch splits FundamentalValue into two new user-defined types, called: BooleanValue and NumberValue. This introduces a new way to create those types in the free store(heap), as: - BooleanValue::New() substitutes Value::CreateBooleanValue(); and new FundamentalValue(); - NumberValue::New() substitutes Value::CreateIntegerValue(), CreateDoubleValue() and new FundamentalValue(); This also introduces three new helper functions: NullValue(); TrueValue(); FalseValue(); - NullValue() substitutes the old way of Value::CreateNullValue() - TrueValue() substitutes the old way of Value::CreateBooleanValue(true); and new FundamentalValue(true); - FalseValue() substitutes the old way of Value::CreateBooleanValue(false); and new FundamentalValue(false); BUG= TEST=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : NullValue::New #

Patch Set 5 : base::StringValue::New #

Patch Set 6 : fixes #

Patch Set 7 : simplify NullValue() calls #

Patch Set 8 : add TrueValue() and FalseValue() #

Patch Set 9 : fix browser_options_handler.cc #

Patch Set 10 : fix a typo and more uses of TrueValue() and FalseValue() #

Patch Set 11 : ; #

Patch Set 12 : fix json_schema_validator.cc ???? #

Patch Set 13 : fix a typo -> Double #

Patch Set 14 : IntegerValue + DoubleValue = NumberValue #

Patch Set 15 : new StringValue two fixes #

Patch Set 16 : static_cast<int> #

Patch Set 17 : fix another typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1531 lines, -1507 lines) Patch
M base/json/json_reader.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -6 lines 0 comments Download
M base/json/json_writer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +10 lines, -10 lines 0 comments Download
M base/value_conversions.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M base/values.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +38 lines, -26 lines 0 comments Download
M base/values.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 11 chunks +113 lines, -86 lines 0 comments Download
M base/values_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 17 chunks +43 lines, -46 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_codec.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_expanded_state_tracker.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_signin.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/cros_settings.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signed_settings_temp_storage.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/user_cros_settings_provider.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/content_settings/content_settings_notification_provider.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/convert_web_app.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bookmark_manager_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_browser_event_router.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/extensions/extension_chrome_auth_private_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_debugger_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_event_router.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_file_browser_private_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_i18n_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_idle_api.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_private_api_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_ime_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 13 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_input_method_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_input_ui_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 3 4 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_management_browsertest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_messages_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_metrics_module.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_omnibox_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_permissions_api.cc View 1 2 3 4 5 6 7 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_pref_value_map_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 20 chunks +25 lines, -27 lines 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 2 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_proxy_api_helpers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_rlz_module.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage_cache.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_settings_storage_unittest.cc View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_sidebar_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_test_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tts_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tts_api_controller.cc View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_tts_engine_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_web_socket_proxy_private_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_webstore_private_api.cc View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extensions_quota_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_policy_extension_loader_unittest.cc View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/file_manager_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/access_token_store.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/media_internals.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/media_internals_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/net/referrer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref_unittest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud_policy_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_provider_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 33 chunks +68 lines, -74 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_delegate_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_mac.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_provider_mac_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_win_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/policy/device_policy_cache_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_map_unittest.cc View 1 2 3 4 5 6 7 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/policy/user_policy_cache.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/policy/user_policy_cache_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/incognito_user_pref_store_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 7 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/prefs/pref_model_associator_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/prefs/pref_notifier_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 16 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/prefs/pref_service_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_set_observer_unittest.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/prefs/pref_value_map.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_value_map_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/prefs/pref_value_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/prefs/session_startup_pref_unittest.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/prefs/testing_pref_store.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/engine/syncapi_unittest.cc View 1 2 3 4 5 6 7 9 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/js/js_arg_list_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 2 12 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_js_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_id.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_prefs.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/shell_dialogs_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/BidiCheckerWebUITest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/bug_report_ui.cc View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_adapter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals_ui.cc View 1 2 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/net_internals_ui_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_sync_setup_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/shown_sections_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 3 4 5 6 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_customize_modifier_keys_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_options_util.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_options_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/system_options_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 4 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/options/handler_options_handler.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_sync_setup_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 1 2 3 4 5 6 7 4 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +38 lines, -36 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 1 2 10 chunks +13 lines, -13 lines 0 comments Download
M chrome/common/common_param_traits_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/common/custom_handlers/protocol_handler.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_set_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/json_pref_store_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/json_schema_validator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/json_schema_validator_unittest_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 17 chunks +70 lines, -70 lines 0 comments Download
M chrome/renderer/automation/dom_automation_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/service_process_prefs.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_json_requests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/javascript_message_utils.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/live_sync/multiple_client_preferences_sync_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/two_client_preferences_sync_test.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/alert_commands.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/appcache_status_command.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/browser_connection_commands.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/create_session.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/screenshot_command.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/session_with_id.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/set_timeout_commands_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/target_locator_commands.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/title_command.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/url_command.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/commands/webdriver_command.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/webdriver/commands/webelement_commands.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/webdriver/dispatch.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/webdriver/dispatch_unittest.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/webdriver/session.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/test/webdriver/web_element_id.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/generate_policy_source.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_blacklist.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_data_manager.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/common/font_list_gtk.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/font_list_mac.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/font_list_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
content/renderer/render_view.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/v8_value_converter.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/v8_value_converter_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +19 lines, -19 lines 0 comments Download
M content/renderer/web_ui_bindings.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +5 lines, -5 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +11 lines, -11 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +5 lines, -5 lines 0 comments Download
M net/base/address_list_net_log_param.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/base/transport_security_state.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_net_log_params.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M net/websockets/websocket_net_log_params.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_net_log_params_unittest.cc View 1 2 3 4 1 chunk +13 lines, -10 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
tfarina
9 years, 4 months ago (2011-08-24 18:33:19 UTC) #1
For my own reference and for preserving it on gmail history.

Powered by Google App Engine
This is Rietveld 408576698