Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Side by Side Diff: chrome/browser/media/media_internals_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/media/media_internals.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/media_internals.h" 5 #include "chrome/browser/media/media_internals.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "chrome/browser/media/media_internals_observer.h" 8 #include "chrome/browser/media/media_internals_observer.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 23 matching lines...) Expand all
34 } 34 }
35 35
36 protected: 36 protected:
37 virtual void SetUp() { 37 virtual void SetUp() {
38 internals_.reset(new MediaInternals()); 38 internals_.reset(new MediaInternals());
39 } 39 }
40 scoped_ptr<MediaInternals> internals_; 40 scoped_ptr<MediaInternals> internals_;
41 }; 41 };
42 42
43 TEST_F(MediaInternalsTest, UpdateAddsNewItem) { 43 TEST_F(MediaInternalsTest, UpdateAddsNewItem) {
44 UpdateItem("some.item", "testing", Value::CreateBooleanValue(true)); 44 UpdateItem("some.item", "testing", base::TrueValue());
45 bool testing = false; 45 bool testing = false;
46 std::string id; 46 std::string id;
47 47
48 EXPECT_TRUE(data()->GetBoolean("some.item.testing", &testing)); 48 EXPECT_TRUE(data()->GetBoolean("some.item.testing", &testing));
49 EXPECT_TRUE(testing); 49 EXPECT_TRUE(testing);
50 50
51 EXPECT_TRUE(data()->GetString("some.item.id", &id)); 51 EXPECT_TRUE(data()->GetString("some.item.id", &id));
52 EXPECT_EQ(id, "some.item"); 52 EXPECT_EQ(id, "some.item");
53 } 53 }
54 54
55 TEST_F(MediaInternalsTest, UpdateModifiesExistingItem) { 55 TEST_F(MediaInternalsTest, UpdateModifiesExistingItem) {
56 UpdateItem("some.item", "testing", Value::CreateBooleanValue(true)); 56 UpdateItem("some.item", "testing", base::TrueValue());
57 UpdateItem("some.item", "value", Value::CreateIntegerValue(5)); 57 UpdateItem("some.item", "value", base::NumberValue::New(5));
58 UpdateItem("some.item", "testing", Value::CreateBooleanValue(false)); 58 UpdateItem("some.item", "testing", base::FalseValue());
59 bool testing = true; 59 bool testing = true;
60 int value = 0; 60 int value = 0;
61 std::string id; 61 std::string id;
62 62
63 EXPECT_TRUE(data()->GetBoolean("some.item.testing", &testing)); 63 EXPECT_TRUE(data()->GetBoolean("some.item.testing", &testing));
64 EXPECT_FALSE(testing); 64 EXPECT_FALSE(testing);
65 65
66 EXPECT_TRUE(data()->GetInteger("some.item.value", &value)); 66 EXPECT_TRUE(data()->GetInteger("some.item.value", &value));
67 EXPECT_EQ(value, 5); 67 EXPECT_EQ(value, 5);
68 68
(...skipping 18 matching lines...) Expand all
87 EXPECT_CALL(*observer.get(), OnUpdate(testing::_)).Times(0); 87 EXPECT_CALL(*observer.get(), OnUpdate(testing::_)).Times(0);
88 88
89 internals_->AddObserver(observer.get()); 89 internals_->AddObserver(observer.get());
90 internals_->RemoveObserver(observer.get()); 90 internals_->RemoveObserver(observer.get());
91 SendUpdate("fn", data()); 91 SendUpdate("fn", data());
92 } 92 }
93 93
94 TEST_F(MediaInternalsTest, DeleteRemovesItem) { 94 TEST_F(MediaInternalsTest, DeleteRemovesItem) {
95 Value* out; 95 Value* out;
96 96
97 UpdateItem("some.item", "testing", Value::CreateNullValue()); 97 UpdateItem("some.item", "testing", base::NullValue());
98 EXPECT_TRUE(data()->Get("some.item", &out)); 98 EXPECT_TRUE(data()->Get("some.item", &out));
99 EXPECT_TRUE(data()->Get("some", &out)); 99 EXPECT_TRUE(data()->Get("some", &out));
100 100
101 DeleteItem("some.item"); 101 DeleteItem("some.item");
102 EXPECT_FALSE(data()->Get("some.item", &out)); 102 EXPECT_FALSE(data()->Get("some.item", &out));
103 EXPECT_TRUE(data()->Get("some", &out)); 103 EXPECT_TRUE(data()->Get("some", &out));
104 104
105 DeleteItem("some"); 105 DeleteItem("some");
106 EXPECT_FALSE(data()->Get("some.item", &out)); 106 EXPECT_FALSE(data()->Get("some.item", &out));
107 EXPECT_FALSE(data()->Get("some", &out)); 107 EXPECT_FALSE(data()->Get("some", &out));
108 } 108 }
OLDNEW
« no previous file with comments | « chrome/browser/media/media_internals.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698