Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/prefs/proxy_policy_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_value_store_unittest.cc ('k') | chrome/browser/prefs/session_startup_pref.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/proxy_policy_unittest.cc
diff --git a/chrome/browser/prefs/proxy_policy_unittest.cc b/chrome/browser/prefs/proxy_policy_unittest.cc
index 55cf4d7adfba80882a5c89d8d4e3ee4c85742b4c..b7e1cad071f1e0e0b267f24ca3130f1a45452e9a 100644
--- a/chrome/browser/prefs/proxy_policy_unittest.cc
+++ b/chrome/browser/prefs/proxy_policy_unittest.cc
@@ -67,13 +67,13 @@ TEST(ProxyPolicyTest, OverridesCommandLineOptions) {
command_line.AppendSwitchASCII(switches::kProxyServer, "789");
scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
new policy::MockConfigurationPolicyProvider());
- Value* mode_name = Value::CreateStringValue(
+ Value* mode_name = base::StringValue::New(
ProxyPrefs::kFixedServersProxyModeName);
provider->AddPolicy(policy::kPolicyProxyMode, mode_name);
provider->AddPolicy(policy::kPolicyProxyBypassList,
- Value::CreateStringValue("abc"));
+ base::StringValue::New("abc"));
provider->AddPolicy(policy::kPolicyProxyServer,
- Value::CreateStringValue("ghi"));
+ base::StringValue::New("ghi"));
// First verify that command-line options are set correctly when
// there is no policy in effect.
@@ -107,7 +107,7 @@ TEST(ProxyPolicyTest, OverridesUnrelatedCommandLineOptions) {
command_line.AppendSwitchASCII(switches::kProxyServer, "789");
scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
new policy::MockConfigurationPolicyProvider());
- Value* mode_name = Value::CreateStringValue(
+ Value* mode_name = base::StringValue::New(
ProxyPrefs::kAutoDetectProxyModeName);
provider->AddPolicy(policy::kPolicyProxyMode, mode_name);
@@ -140,7 +140,7 @@ TEST(ProxyPolicyTest, OverridesCommandLineNoProxy) {
command_line.AppendSwitch(switches::kNoProxyServer);
scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
new policy::MockConfigurationPolicyProvider());
- Value* mode_name = Value::CreateStringValue(
+ Value* mode_name = base::StringValue::New(
ProxyPrefs::kAutoDetectProxyModeName);
provider->AddPolicy(policy::kPolicyProxyMode, mode_name);
@@ -169,7 +169,7 @@ TEST(ProxyPolicyTest, OverridesCommandLineAutoDetect) {
command_line.AppendSwitch(switches::kProxyAutoDetect);
scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
new policy::MockConfigurationPolicyProvider());
- Value* mode_name = Value::CreateStringValue(
+ Value* mode_name = base::StringValue::New(
ProxyPrefs::kDirectProxyModeName);
provider->AddPolicy(policy::kPolicyProxyMode, mode_name);
« no previous file with comments | « chrome/browser/prefs/pref_value_store_unittest.cc ('k') | chrome/browser/prefs/session_startup_pref.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698