Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3496)

Unified Diff: chrome/browser/extensions/extension_webnavigation_api.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_webnavigation_api.cc
diff --git a/chrome/browser/extensions/extension_webnavigation_api.cc b/chrome/browser/extensions/extension_webnavigation_api.cc
index 4a6a9a92d1dc48f8cf6a3be4937a38339e8cba64..997bb4d1b5343d2de1cc1fcd4bf1b25ae2c1c14f 100644
--- a/chrome/browser/extensions/extension_webnavigation_api.cc
+++ b/chrome/browser/extensions/extension_webnavigation_api.cc
@@ -103,11 +103,11 @@ void DispatchOnCommitted(TabContents* tab_contents,
PageTransition::CoreTransitionString(transition_type));
ListValue* qualifiers = new ListValue();
if (transition_type & PageTransition::CLIENT_REDIRECT)
- qualifiers->Append(Value::CreateStringValue("client_redirect"));
+ qualifiers->Append(base::StringValue::New("client_redirect"));
if (transition_type & PageTransition::SERVER_REDIRECT)
- qualifiers->Append(Value::CreateStringValue("server_redirect"));
+ qualifiers->Append(base::StringValue::New("server_redirect"));
if (transition_type & PageTransition::FORWARD_BACK)
- qualifiers->Append(Value::CreateStringValue("forward_back"));
+ qualifiers->Append(base::StringValue::New("forward_back"));
dict->Set(keys::kTransitionQualifiersKey, qualifiers);
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
@@ -599,7 +599,7 @@ bool GetFrameFunction::RunImpl() {
EXTENSION_FUNCTION_VALIDATE(
details->GetInteger(keys::kFrameIdKey, &frame_id));
- result_.reset(Value::CreateNullValue());
+ result_.reset(base::NullValue());
TabContentsWrapper* wrapper;
if (!ExtensionTabUtil::GetTabById(
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/extensions/extension_webrequest_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698