Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: chrome/browser/ui/webui/ntp/app_launcher_handler.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/app_launcher_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
index 48b5a8dd1621962b9d3f80fa7486c7a23c35504f..2a4e72e9f57ceeefcaa78d8fde732b2c26f7dc22 100644
--- a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
+++ b/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
@@ -254,7 +254,7 @@ void AppLauncherHandler::Observe(int type,
const AppNotification* notification =
extension_service_->app_notification_manager()->GetLast(id);
ListValue args;
- args.Append(new StringValue(id));
+ args.Append(base::StringValue::New(id));
if (notification)
args.Append(SerializeNotification(*notification));
web_ui_->CallJavascriptFunction("appNotificationChanged", args);
@@ -682,7 +682,7 @@ void AppLauncherHandler::HandleSaveAppPageName(const ListValue* args) {
PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
ListPrefUpdate update(prefs, prefs::kNTPAppPageNames);
ListValue* list = update.Get();
- list->Set(static_cast<size_t>(page_index), Value::CreateStringValue(name));
+ list->Set(static_cast<size_t>(page_index), base::StringValue::New(name));
}
void AppLauncherHandler::HandleGenerateAppForLink(const ListValue* args) {
@@ -821,7 +821,7 @@ void AppLauncherHandler::PromptToEnableApp(const std::string& extension_id) {
extension_service_->EnableExtension(extension_id);
// Launch app asynchronously so the image will update.
- StringValue* app_id = Value::CreateStringValue(extension_id);
+ StringValue* app_id = base::StringValue::New(extension_id);
web_ui_->CallJavascriptFunction("launchAppAfterEnable", *app_id);
return;
}
@@ -871,7 +871,7 @@ void AppLauncherHandler::InstallUIProceed() {
// If we don't launch the app asynchronously, then the app's disabled
// icon disappears but isn't replaced by the enabled icon, making a poor
// visual experience.
- StringValue* app_id = Value::CreateStringValue(extension->id());
+ StringValue* app_id = base::StringValue::New(extension->id());
web_ui_->CallJavascriptFunction("launchAppAfterEnable", *app_id);
extension_id_prompting_ = "";
« no previous file with comments | « chrome/browser/ui/webui/net_internals_ui_browsertest.cc ('k') | chrome/browser/ui/webui/ntp/favicon_webui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698