Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2381)

Unified Diff: chrome/browser/extensions/extension_messages_browsertest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_messages_browsertest.cc
diff --git a/chrome/browser/extensions/extension_messages_browsertest.cc b/chrome/browser/extensions/extension_messages_browsertest.cc
index ace9c0c270b2115d909b27a5e45fa2b0f728fa89..b4b8ad3e2e075afccc26ef3e091d33050da657bd 100644
--- a/chrome/browser/extensions/extension_messages_browsertest.cc
+++ b/chrome/browser/extensions/extension_messages_browsertest.cc
@@ -15,29 +15,29 @@
static void DispatchOnConnect(int source_port_id, const std::string& name,
const std::string& tab_json) {
ListValue args;
- args.Set(0, Value::CreateIntegerValue(source_port_id));
- args.Set(1, Value::CreateStringValue(name));
- args.Set(2, Value::CreateStringValue(tab_json));
+ args.Set(0, base::NumberValue::New(source_port_id));
+ args.Set(1, base::StringValue::New(name));
+ args.Set(2, base::StringValue::New(tab_json));
// Testing extensionId. Set in EventBindings::HandleContextCreated.
// We use the same id for source & target to similute an extension "talking
// to itself".
- args.Set(3, Value::CreateStringValue(EventBindings::kTestingExtensionId));
- args.Set(4, Value::CreateStringValue(EventBindings::kTestingExtensionId));
+ args.Set(3, base::StringValue::New(EventBindings::kTestingExtensionId));
+ args.Set(4, base::StringValue::New(EventBindings::kTestingExtensionId));
EventBindings::CallFunction(
"", ExtensionMessageService::kDispatchOnConnect, args, NULL, GURL());
}
static void DispatchOnDisconnect(int source_port_id) {
ListValue args;
- args.Set(0, Value::CreateIntegerValue(source_port_id));
+ args.Set(0, base::NumberValue::New(source_port_id));
EventBindings::CallFunction(
"", ExtensionMessageService::kDispatchOnDisconnect, args, NULL, GURL());
}
static void DispatchOnMessage(const std::string& message, int source_port_id) {
ListValue args;
- args.Set(0, Value::CreateStringValue(message));
- args.Set(1, Value::CreateIntegerValue(source_port_id));
+ args.Set(0, base::StringValue::New(message));
+ args.Set(1, base::NumberValue::New(source_port_id));
EventBindings::CallFunction(
"", ExtensionMessageService::kDispatchOnMessage, args, NULL, GURL());
}
« no previous file with comments | « chrome/browser/extensions/extension_message_service.cc ('k') | chrome/browser/extensions/extension_metrics_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698