Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: base/json/json_writer_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/json/json_reader.cc ('k') | base/value_conversions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_writer.h" 5 #include "base/json/json_writer.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace base { 9 namespace base {
10 10
11 TEST(JSONWriterTest, Writing) { 11 TEST(JSONWriterTest, Writing) {
12 // Test null 12 // Test null
13 Value* root = Value::CreateNullValue(); 13 Value* root = NullValue();
14 std::string output_js; 14 std::string output_js;
15 JSONWriter::Write(root, false, &output_js); 15 JSONWriter::Write(root, false, &output_js);
16 ASSERT_EQ("null", output_js); 16 ASSERT_EQ("null", output_js);
17 delete root; 17 delete root;
18 18
19 // Test empty dict 19 // Test empty dict
20 root = new DictionaryValue; 20 root = new DictionaryValue;
21 JSONWriter::Write(root, false, &output_js); 21 JSONWriter::Write(root, false, &output_js);
22 ASSERT_EQ("{}", output_js); 22 ASSERT_EQ("{}", output_js);
23 delete root; 23 delete root;
24 24
25 // Test empty list 25 // Test empty list
26 root = new ListValue; 26 root = new ListValue;
27 JSONWriter::Write(root, false, &output_js); 27 JSONWriter::Write(root, false, &output_js);
28 ASSERT_EQ("[]", output_js); 28 ASSERT_EQ("[]", output_js);
29 delete root; 29 delete root;
30 30
31 // Test Real values should always have a decimal or an 'e'. 31 // Test Real values should always have a decimal or an 'e'.
32 root = Value::CreateDoubleValue(1.0); 32 root = NumberValue::New(1.0);
33 JSONWriter::Write(root, false, &output_js); 33 JSONWriter::Write(root, false, &output_js);
34 ASSERT_EQ("1.0", output_js); 34 ASSERT_EQ("1.0", output_js);
35 delete root; 35 delete root;
36 36
37 // Test Real values in the the range (-1, 1) must have leading zeros 37 // Test Real values in the the range (-1, 1) must have leading zeros
38 root = Value::CreateDoubleValue(0.2); 38 root = NumberValue::New(0.2);
39 JSONWriter::Write(root, false, &output_js); 39 JSONWriter::Write(root, false, &output_js);
40 ASSERT_EQ("0.2", output_js); 40 ASSERT_EQ("0.2", output_js);
41 delete root; 41 delete root;
42 42
43 // Test Real values in the the range (-1, 1) must have leading zeros 43 // Test Real values in the the range (-1, 1) must have leading zeros
44 root = Value::CreateDoubleValue(-0.8); 44 root = NumberValue::New(-0.8);
45 JSONWriter::Write(root, false, &output_js); 45 JSONWriter::Write(root, false, &output_js);
46 ASSERT_EQ("-0.8", output_js); 46 ASSERT_EQ("-0.8", output_js);
47 delete root; 47 delete root;
48 48
49 // Writer unittests like empty list/dict nesting, 49 // Writer unittests like empty list/dict nesting,
50 // list list nesting, etc. 50 // list list nesting, etc.
51 DictionaryValue root_dict; 51 DictionaryValue root_dict;
52 ListValue* list = new ListValue; 52 ListValue* list = new ListValue;
53 root_dict.Set("list", list); 53 root_dict.Set("list", list);
54 DictionaryValue* inner_dict = new DictionaryValue; 54 DictionaryValue* inner_dict = new DictionaryValue;
55 list->Append(inner_dict); 55 list->Append(inner_dict);
56 inner_dict->SetInteger("inner int", 10); 56 inner_dict->SetInteger("inner int", 10);
57 ListValue* inner_list = new ListValue; 57 ListValue* inner_list = new ListValue;
58 list->Append(inner_list); 58 list->Append(inner_list);
59 list->Append(Value::CreateBooleanValue(true)); 59 list->Append(TrueValue());
60 60
61 // Test the pretty-printer. 61 // Test the pretty-printer.
62 JSONWriter::Write(&root_dict, false, &output_js); 62 JSONWriter::Write(&root_dict, false, &output_js);
63 ASSERT_EQ("{\"list\":[{\"inner int\":10},[],true]}", output_js); 63 ASSERT_EQ("{\"list\":[{\"inner int\":10},[],true]}", output_js);
64 JSONWriter::Write(&root_dict, true, &output_js); 64 JSONWriter::Write(&root_dict, true, &output_js);
65 // The pretty-printer uses a different newline style on Windows than on 65 // The pretty-printer uses a different newline style on Windows than on
66 // other platforms. 66 // other platforms.
67 #if defined(OS_WIN) 67 #if defined(OS_WIN)
68 #define JSON_NEWLINE "\r\n" 68 #define JSON_NEWLINE "\r\n"
69 #else 69 #else
70 #define JSON_NEWLINE "\n" 70 #define JSON_NEWLINE "\n"
71 #endif 71 #endif
72 ASSERT_EQ("{" JSON_NEWLINE 72 ASSERT_EQ("{" JSON_NEWLINE
73 " \"list\": [ {" JSON_NEWLINE 73 " \"list\": [ {" JSON_NEWLINE
74 " \"inner int\": 10" JSON_NEWLINE 74 " \"inner int\": 10" JSON_NEWLINE
75 " }, [ ], true ]" JSON_NEWLINE 75 " }, [ ], true ]" JSON_NEWLINE
76 "}" JSON_NEWLINE, 76 "}" JSON_NEWLINE,
77 output_js); 77 output_js);
78 #undef JSON_NEWLINE 78 #undef JSON_NEWLINE
79 79
80 // Test keys with periods 80 // Test keys with periods
81 DictionaryValue period_dict; 81 DictionaryValue period_dict;
82 period_dict.SetWithoutPathExpansion("a.b", Value::CreateIntegerValue(3)); 82 period_dict.SetWithoutPathExpansion("a.b", NumberValue::New(3));
83 period_dict.SetWithoutPathExpansion("c", Value::CreateIntegerValue(2)); 83 period_dict.SetWithoutPathExpansion("c", NumberValue::New(2));
84 DictionaryValue* period_dict2 = new DictionaryValue; 84 DictionaryValue* period_dict2 = new DictionaryValue;
85 period_dict2->SetWithoutPathExpansion("g.h.i.j", 85 period_dict2->SetWithoutPathExpansion("g.h.i.j",
86 Value::CreateIntegerValue(1)); 86 NumberValue::New(1));
87 period_dict.SetWithoutPathExpansion("d.e.f", period_dict2); 87 period_dict.SetWithoutPathExpansion("d.e.f", period_dict2);
88 JSONWriter::Write(&period_dict, false, &output_js); 88 JSONWriter::Write(&period_dict, false, &output_js);
89 ASSERT_EQ("{\"a.b\":3,\"c\":2,\"d.e.f\":{\"g.h.i.j\":1}}", output_js); 89 ASSERT_EQ("{\"a.b\":3,\"c\":2,\"d.e.f\":{\"g.h.i.j\":1}}", output_js);
90 90
91 DictionaryValue period_dict3; 91 DictionaryValue period_dict3;
92 period_dict3.Set("a.b", Value::CreateIntegerValue(2)); 92 period_dict3.Set("a.b", NumberValue::New(2));
93 period_dict3.SetWithoutPathExpansion("a.b", Value::CreateIntegerValue(1)); 93 period_dict3.SetWithoutPathExpansion("a.b", NumberValue::New(1));
94 JSONWriter::Write(&period_dict3, false, &output_js); 94 JSONWriter::Write(&period_dict3, false, &output_js);
95 ASSERT_EQ("{\"a\":{\"b\":2},\"a.b\":1}", output_js); 95 ASSERT_EQ("{\"a\":{\"b\":2},\"a.b\":1}", output_js);
96 } 96 }
97 97
98 } // namespace base 98 } // namespace base
OLDNEW
« no previous file with comments | « base/json/json_reader.cc ('k') | base/value_conversions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698