Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/test/webdriver/dispatch_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/dispatch.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/webdriver/dispatch_unittest.cc
diff --git a/chrome/test/webdriver/dispatch_unittest.cc b/chrome/test/webdriver/dispatch_unittest.cc
index 167f68482cadc20a1d021a1e116baee94b680cc2..c75c12ce13dcbde0a9a9a3aaa93e2e98434e19d1 100644
--- a/chrome/test/webdriver/dispatch_unittest.cc
+++ b/chrome/test/webdriver/dispatch_unittest.cc
@@ -47,7 +47,7 @@ TEST(DispatchTest, CorrectlyConvertsResponseCodesToHttpStatusCodes) {
HttpResponse http_response;
Response command_response;
- command_response.SetValue(Value::CreateStringValue("foobar"));
+ command_response.SetValue(base::StringValue::New("foobar"));
command_response.SetStatus(kSuccess);
ExpectHttpStatus(HttpResponse::kOk, command_response, &http_response);
@@ -66,8 +66,8 @@ TEST(DispatchTest, CorrectlyConvertsResponseCodesToHttpStatusCodes) {
&http_response);
ListValue* methods = new ListValue;
- methods->Append(Value::CreateStringValue("POST"));
- methods->Append(Value::CreateStringValue("GET"));
+ methods->Append(base::StringValue::New("POST"));
+ methods->Append(base::StringValue::New("GET"));
command_response.SetValue(methods);
command_response.SetStatus(kMethodNotAllowed);
ExpectHttpStatus(HttpResponse::kMethodNotAllowed, command_response,
@@ -94,11 +94,11 @@ TEST(DispatchTest, CorrectlyConvertsResponseCodesToHttpStatusCodes) {
TEST(DispatchTest,
ReturnsAnErrorOnNonStringMethodsListedOnAMethodNotAllowedResponse) {
ListValue* methods = new ListValue;
- methods->Append(Value::CreateStringValue("POST"));
+ methods->Append(base::StringValue::New("POST"));
methods->Append(new DictionaryValue);
- methods->Append(Value::CreateStringValue("GET"));
+ methods->Append(base::StringValue::New("GET"));
methods->Append(new DictionaryValue);
- methods->Append(Value::CreateStringValue("DELETE"));
+ methods->Append(base::StringValue::New("DELETE"));
Response command_response;
command_response.SetStatus(kMethodNotAllowed);
@@ -114,7 +114,7 @@ TEST(DispatchTest, ReturnsCommandResponseAsJson) {
Response command_response;
command_response.SetStatus(kSuccess);
- command_response.SetValue(Value::CreateStringValue("foobar"));
+ command_response.SetValue(base::StringValue::New("foobar"));
HttpResponse http_response;
internal::PrepareHttpResponse(command_response, &http_response);
« no previous file with comments | « chrome/test/webdriver/dispatch.cc ('k') | chrome/test/webdriver/session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698