Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5055)

Unified Diff: chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc
diff --git a/chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc b/chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc
index 8a5ac4636d105fc59711aee6a0516dd0a5902522..084ba49bbc0f9a58e897e82d4dd1a44d1a4d5b1e 100644
--- a/chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc
+++ b/chrome/browser/extensions/extension_proxy_api_helpers_unittest.cc
@@ -195,8 +195,8 @@ TEST(ExtensionProxyApiHelpers, GetBypassListFromExtensionPref) {
EXPECT_FALSE(bad_message);
ListValue* bypass_list = new ListValue;
- bypass_list->Append(Value::CreateStringValue("host1"));
- bypass_list->Append(Value::CreateStringValue("host2"));
+ bypass_list->Append(base::StringValue::New("host1"));
+ bypass_list->Append(base::StringValue::New("host2"));
DictionaryValue* proxy_rules = new DictionaryValue;
proxy_rules->Set(keys::kProxyConfigBypassList, bypass_list);
proxy_config.Set(keys::kProxyConfigRules, proxy_rules);
@@ -282,9 +282,9 @@ TEST(ExtensionProxyApiHelpers, GetProxyServer) {
TEST(ExtensionProxyApiHelpers, JoinUrlList) {
bool bad_message = false;
ListValue list;
- list.Append(Value::CreateStringValue("s1"));
- list.Append(Value::CreateStringValue("s2"));
- list.Append(Value::CreateStringValue("s3"));
+ list.Append(base::StringValue::New("s1"));
+ list.Append(base::StringValue::New("s2"));
+ list.Append(base::StringValue::New("s3"));
std::string out;
std::string error;
@@ -313,7 +313,7 @@ TEST(ExtensionProxyApiHelpers, CreateProxyRulesDict) {
expected->Set("fallbackProxy",
CreateTestProxyServerDict("socks4", "proxy4", 80));
ListValue* bypass_list = new ListValue;
- bypass_list->Append(Value::CreateStringValue("localhost"));
+ bypass_list->Append(base::StringValue::New("localhost"));
expected->Set(keys::kProxyConfigBypassList, bypass_list);
EXPECT_TRUE(Value::Equals(expected.get(), extension_pref.get()));
@@ -351,9 +351,9 @@ TEST(ExtensionProxyApiHelpers, CreatePacScriptDictWidthData) {
TEST(ExtensionProxyApiHelpers, TokenizeToStringList) {
ListValue expected;
- expected.Append(Value::CreateStringValue("s1"));
- expected.Append(Value::CreateStringValue("s2"));
- expected.Append(Value::CreateStringValue("s3"));
+ expected.Append(base::StringValue::New("s1"));
+ expected.Append(base::StringValue::New("s2"));
+ expected.Append(base::StringValue::New("s3"));
scoped_ptr<ListValue> out(TokenizeToStringList("s1;s2;s3", ";"));
EXPECT_TRUE(Value::Equals(&expected, out.get()));
« no previous file with comments | « chrome/browser/extensions/extension_proxy_api_helpers.cc ('k') | chrome/browser/extensions/extension_rlz_module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698