chrome/test/webdriver/commands/browser_connection_commands.cc - Issue 7649006: more changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/webdriver/commands/browser_connection_commands.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix another typo Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/webdriver/commands/browser_connection_commands.h"	5 #include "chrome/test/webdriver/commands/browser_connection_commands.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "chrome/test/webdriver/commands/response.h"	9 #include "chrome/test/webdriver/commands/response.h"

10 #include "chrome/test/webdriver/session.h"	10 #include "chrome/test/webdriver/session.h"

(...skipping 12 matching lines...) Expand all Loading...
23 return true;	23 return true;

24 }	24 }

25	25

26 void BrowserConnectionCommand::ExecuteGet(Response* const response) {	26 void BrowserConnectionCommand::ExecuteGet(Response* const response) {

27 bool online;	27 bool online;

28 Error* error = session_->GetBrowserConnectionState(&online);	28 Error* error = session_->GetBrowserConnectionState(&online);

29 if (error) {	29 if (error) {

30 response->SetError(error);	30 response->SetError(error);

31 return;	31 return;

32 }	32 }

33 response->SetValue(new base::FundamentalValue(online));	33 response->SetValue(base::BooleanValue::New(online));

34 }	34 }

35	35

36 } // namespace webdriver	36 } // namespace webdriver

OLD	NEW