Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: chrome/browser/ui/webui/net_internals_ui_browsertest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/net_internals_ui.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/net_internals_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals_ui_browsertest.cc
index ff40a6bfac4e5af8e1da9850c9b121d21b78a3ab..967a23b1dcf5c161b10bc5b66b056477287c323b 100644
--- a/chrome/browser/ui/webui/net_internals_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/net_internals_ui_browsertest.cc
@@ -236,12 +236,12 @@ IN_PROC_BROWSER_TEST_F(NetInternalsTest, NetInternalsTestViewPassTwice) {
RunTestAndWaitForTitle(
"NetInternalsTestView",
// URL that results in success.
- Value::CreateStringValue(
+ base::StringValue::New(
test_server()->GetURL("files/title1.html").spec()),
// Resulting error code of the first test.
- Value::CreateIntegerValue(net::OK),
+ base::NumberValue::New(net::OK),
// Number of times to run the test suite.
- Value::CreateIntegerValue(2));
+ base::NumberValue::New(2));
}
// Runs the test suite twice, expecting a failing result the first time. Checks
@@ -251,11 +251,11 @@ IN_PROC_BROWSER_TEST_F(NetInternalsTest, NetInternalsTestViewFailTwice) {
RunTestAndWaitForTitle(
"NetInternalsTestView",
// URL that results in an error, due to the port.
- Value::CreateStringValue("http://127.0.0.1:7/"),
+ base::StringValue::New("http://127.0.0.1:7/"),
// Resulting error code of the first test.
- Value::CreateIntegerValue(net::ERR_UNSAFE_PORT),
+ base::NumberValue::New(net::ERR_UNSAFE_PORT),
// Number of times to run the test suite.
- Value::CreateIntegerValue(2));
+ base::NumberValue::New(2));
}
////////////////////////////////////////////////////////////////////////////////
@@ -268,10 +268,10 @@ IN_PROC_BROWSER_TEST_F(NetInternalsTest, NetInternalsPrerenderViewSucceed) {
RunTestAndWaitForTitle(
"NetInternalsPrerenderView",
// URL that can be prerendered.
- Value::CreateStringValue(
+ base::StringValue::New(
test_server()->GetURL("files/title1.html").spec()),
- Value::CreateBooleanValue(true),
- Value::CreateStringValue(
+ base::TrueValue(),
+ base::StringValue::New(
prerender::NameFromFinalStatus(prerender::FINAL_STATUS_USED)));
}
@@ -281,10 +281,10 @@ IN_PROC_BROWSER_TEST_F(NetInternalsTest, NetInternalsPrerenderViewFail) {
RunTestAndWaitForTitle(
"NetInternalsPrerenderView",
// URL that can't be prerendered, since it triggers a download.
- Value::CreateStringValue(
+ base::StringValue::New(
test_server()->GetURL("files/download-test1.lib").spec()),
- Value::CreateBooleanValue(false),
- Value::CreateStringValue(
+ base::FalseValue(),
+ base::StringValue::New(
prerender::NameFromFinalStatus(prerender::FINAL_STATUS_DOWNLOAD)));
}
« no previous file with comments | « chrome/browser/ui/webui/net_internals_ui.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698