Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Unified Diff: chrome/browser/extensions/extension_management_api.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_management_api.cc
diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc
index e69a626202ea6a724acecd972e4fd4155e48ea31..dd31e3d21c14db09fb62f37ae03295178c94879b 100644
--- a/chrome/browser/extensions/extension_management_api.cc
+++ b/chrome/browser/extensions/extension_management_api.cc
@@ -101,7 +101,7 @@ static DictionaryValue* CreateExtensionInfo(const Extension& extension,
if (!perms.empty()) {
std::set<std::string>::const_iterator perms_iter;
for (perms_iter = perms.begin(); perms_iter != perms.end(); ++perms_iter) {
- StringValue* permission_name = new StringValue(*perms_iter);
+ StringValue* permission_name = base::StringValue::New(*perms_iter);
permission_list->Append(permission_name);
}
}
@@ -117,7 +117,8 @@ static DictionaryValue* CreateExtensionInfo(const Extension& extension,
for (host_perms_iter = host_perms.begin();
host_perms_iter != host_perms.end();
++host_perms_iter) {
- StringValue* name = new StringValue(host_perms_iter->GetAsString());
+ StringValue* name =
+ base::StringValue::New(host_perms_iter->GetAsString());
host_permission_list->Append(name);
}
}
@@ -182,7 +183,7 @@ bool GetPermissionWarningsByIdFunction::RunImpl() {
ListValue* result = new ListValue();
for (ExtensionPermissionMessages::const_iterator i = warnings.begin();
i < warnings.end(); ++i)
- result->Append(Value::CreateStringValue(i->message()));
+ result->Append(base::StringValue::New(i->message()));
result_.reset(result);
return true;
}
@@ -308,7 +309,7 @@ void GetPermissionWarningsByManifestFunction::OnParseSuccess(
ListValue* result = new ListValue();
for (ExtensionPermissionMessages::const_iterator i = warnings.begin();
i < warnings.end(); ++i)
- result->Append(Value::CreateStringValue(i->message()));
+ result->Append(base::StringValue::New(i->message()));
result_.reset(result);
SendResponse(true);
@@ -460,7 +461,7 @@ void ExtensionManagementEventRouter::Observe(
if (event_name == events::kOnExtensionUninstalled) {
const std::string& extension_id =
Details<UninstalledExtensionInfo>(details).ptr()->extension_id;
- args.Append(Value::CreateStringValue(extension_id));
+ args.Append(base::StringValue::New(extension_id));
} else {
const Extension* extension = NULL;
if (event_name == events::kOnExtensionDisabled) {
« no previous file with comments | « chrome/browser/extensions/extension_input_ui_api.cc ('k') | chrome/browser/extensions/extension_management_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698