Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: chrome/browser/prefs/pref_service_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_set_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_service_unittest.cc
diff --git a/chrome/browser/prefs/pref_service_unittest.cc b/chrome/browser/prefs/pref_service_unittest.cc
index f2f69353180a72e40805e3c5e73182198dcba231..f7149a629cb89d21cb977d109282ec889b652195 100644
--- a/chrome/browser/prefs/pref_service_unittest.cc
+++ b/chrome/browser/prefs/pref_service_unittest.cc
@@ -110,7 +110,7 @@ TEST(PrefServiceTest, Observers) {
const char pref_name[] = "homepage";
TestingPrefService prefs;
- prefs.SetUserPref(pref_name, Value::CreateStringValue("http://www.cnn.com"));
+ prefs.SetUserPref(pref_name, base::StringValue::New("http://www.cnn.com"));
prefs.RegisterStringPref(pref_name, std::string());
const char new_pref_value[] = "http://www.google.com/";
@@ -156,7 +156,7 @@ TEST(PrefServiceTest, GetValueChangedType) {
// Check falling back to a recommended value.
prefs.SetUserPref(prefs::kStabilityLaunchCount,
- Value::CreateStringValue("not an integer"));
+ base::StringValue::New("not an integer"));
const PrefService::Preference* pref =
prefs.FindPreference(prefs::kStabilityLaunchCount);
ASSERT_TRUE(pref);
@@ -241,7 +241,7 @@ TEST_F(PrefServiceSetValueTest, SetListValue) {
Mock::VerifyAndClearExpectations(&observer_);
ListValue new_value;
- new_value.Append(Value::CreateStringValue(kValue));
+ new_value.Append(base::StringValue::New(kValue));
observer_.Expect(&prefs_, kName, &new_value);
prefs_.Set(kName, new_value);
Mock::VerifyAndClearExpectations(&observer_);
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/pref_set_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698