Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview_handler.h ('k') | chrome/browser/ui/webui/print_preview_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc
index 77b694fcf338644d23e7cdb0bd94ec4e88ac11ff..61aa2c0b4831a7aa7abb17f324ea11d56690b8f6 100644
--- a/chrome/browser/ui/webui/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview_handler.cc
@@ -186,10 +186,10 @@ class PrintSystemTaskProxy
VLOG(1) << "Get default printer start";
StringValue* default_printer = NULL;
if (PrintPreviewHandler::last_used_printer_name_ == NULL) {
- default_printer = new StringValue(
+ default_printer = base::StringValue::New(
print_backend_->GetDefaultPrinterName());
} else {
- default_printer = new StringValue(
+ default_printer = base::StringValue::New(
*PrintPreviewHandler::last_used_printer_name_);
}
std::string default_printer_string;
@@ -199,10 +199,10 @@ class PrintSystemTaskProxy
StringValue* cloud_print_data = NULL;
if (PrintPreviewHandler::last_used_printer_cloud_print_data_ != NULL) {
- cloud_print_data = new StringValue(
+ cloud_print_data = base::StringValue::New(
*PrintPreviewHandler::last_used_printer_cloud_print_data_);
} else {
- cloud_print_data = new StringValue("");
+ cloud_print_data = base::StringValue::New("");
}
BrowserThread::PostTask(
@@ -693,7 +693,7 @@ void PrintPreviewHandler::SendDefaultPrinter(
void PrintPreviewHandler::SetupPrinterList(const ListValue& printers) {
SendCloudPrintEnabled();
web_ui_->CallJavascriptFunction("setPrinters", printers,
- *(Value::CreateBooleanValue(true)));
+ *(base::TrueValue()));
}
void PrintPreviewHandler::SendCloudPrintEnabled() {
@@ -705,7 +705,7 @@ void PrintPreviewHandler::SendCloudPrintEnabled() {
#endif
GURL gcp_url(CloudPrintURL(BrowserList::GetLastActive()->profile()).
GetCloudPrintServiceURL());
- base::FundamentalValue enable(enable_cloud_print_integration);
+ base::BooleanValue enable(enable_cloud_print_integration);
base::StringValue gcp_url_value(gcp_url.spec());
web_ui_->CallJavascriptFunction("setUseCloudPrint", enable, gcp_url_value);
}
« no previous file with comments | « chrome/browser/ui/webui/print_preview_handler.h ('k') | chrome/browser/ui/webui/print_preview_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698