Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: chrome/browser/prefs/pref_set_observer_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_service_unittest.cc ('k') | chrome/browser/prefs/pref_value_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_set_observer_unittest.cc
diff --git a/chrome/browser/prefs/pref_set_observer_unittest.cc b/chrome/browser/prefs/pref_set_observer_unittest.cc
index c3f7a1265cd8419ad3e7ca7a1967afd66759a91e..bf22a8f418d4e9051f0c0d8335f1ee42360f7a81 100644
--- a/chrome/browser/prefs/pref_set_observer_unittest.cc
+++ b/chrome/browser/prefs/pref_set_observer_unittest.cc
@@ -50,10 +50,10 @@ TEST_F(PrefSetObserverTest, IsManaged) {
scoped_ptr<PrefSetObserver> pref_set(CreatePrefSetObserver(NULL));
EXPECT_FALSE(pref_set->IsManaged());
pref_service_->SetManagedPref(prefs::kHomePage,
- Value::CreateStringValue("http://crbug.com"));
+ base::StringValue::New("http://crbug.com"));
EXPECT_TRUE(pref_set->IsManaged());
pref_service_->SetManagedPref(prefs::kHomePageIsNewTabPage,
- Value::CreateBooleanValue(true));
+ base::TrueValue());
EXPECT_TRUE(pref_set->IsManaged());
pref_service_->RemoveManagedPref(prefs::kHomePage);
EXPECT_TRUE(pref_set->IsManaged());
@@ -78,19 +78,18 @@ TEST_F(PrefSetObserverTest, Observe) {
Source<PrefService>(pref_service_.get()),
PrefNameDetails(prefs::kHomePage)));
pref_service_->SetUserPref(prefs::kHomePage,
- Value::CreateStringValue("http://crbug.com"));
+ base::StringValue::New("http://crbug.com"));
Mock::VerifyAndClearExpectations(&observer);
EXPECT_CALL(observer,
Observe(int(chrome::NOTIFICATION_PREF_CHANGED),
Source<PrefService>(pref_service_.get()),
PrefNameDetails(prefs::kHomePageIsNewTabPage)));
- pref_service_->SetUserPref(prefs::kHomePageIsNewTabPage,
- Value::CreateBooleanValue(true));
+ pref_service_->SetUserPref(prefs::kHomePageIsNewTabPage, base::TrueValue());
Mock::VerifyAndClearExpectations(&observer);
EXPECT_CALL(observer, Observe(_, _, _)).Times(0);
pref_service_->SetUserPref(prefs::kApplicationLocale,
- Value::CreateStringValue("en_US.utf8"));
+ base::StringValue::New("en_US.utf8"));
Mock::VerifyAndClearExpectations(&observer);
}
« no previous file with comments | « chrome/browser/prefs/pref_service_unittest.cc ('k') | chrome/browser/prefs/pref_value_map.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698