Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: chrome/browser/extensions/external_policy_extension_loader_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/extensions/file_manager_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_policy_extension_loader_unittest.cc
diff --git a/chrome/browser/extensions/external_policy_extension_loader_unittest.cc b/chrome/browser/extensions/external_policy_extension_loader_unittest.cc
index 1598b62171c67834f463c7e28bd0a9881c87f132..da2f77fede3133ccea8ad9501d1bdc53c635cd22 100644
--- a/chrome/browser/extensions/external_policy_extension_loader_unittest.cc
+++ b/chrome/browser/extensions/external_policy_extension_loader_unittest.cc
@@ -104,9 +104,9 @@ class MockExternalPolicyExtensionProviderVisitor
TEST_F(ExternalPolicyExtensionProviderTest, PolicyIsParsed) {
ListValue forced_extensions;
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;http://www.example.com/crx?a=5;b=6"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"
"https://clients2.google.com/service/update2/crx"));
@@ -122,22 +122,22 @@ TEST_F(ExternalPolicyExtensionProviderTest, InvalidPolicyIsNotParsed) {
valid_extensions.Append(valid.DeepCopy());
forced_extensions.Append(valid.DeepCopy());
// Add invalid strings:
- forced_extensions.Append(Value::CreateStringValue(""));
- forced_extensions.Append(Value::CreateStringValue(";"));
- forced_extensions.Append(Value::CreateStringValue(";;"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(""));
+ forced_extensions.Append(base::StringValue::New(";"));
+ forced_extensions.Append(base::StringValue::New(";;"));
+ forced_extensions.Append(base::StringValue::New(
";http://www.example.com/crx"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
";aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"http://www.example.com/crx;aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;http#//www.example.com/crx"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"));
- forced_extensions.Append(Value::CreateStringValue(
+ forced_extensions.Append(base::StringValue::New(
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaahttp#//www.example.com/crx"));
MockExternalPolicyExtensionProviderVisitor mv;
« no previous file with comments | « chrome/browser/extensions/extensions_ui.cc ('k') | chrome/browser/extensions/file_manager_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698