Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/media/media_internals_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/media_internals.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/media_internals_unittest.cc
diff --git a/chrome/browser/media/media_internals_unittest.cc b/chrome/browser/media/media_internals_unittest.cc
index 9e6ce59c1287bca66c9e85d213e7db71b91e303f..22cc0e41e816a8164c2a97d3b5c95d5af4b20caa 100644
--- a/chrome/browser/media/media_internals_unittest.cc
+++ b/chrome/browser/media/media_internals_unittest.cc
@@ -41,7 +41,7 @@ class MediaInternalsTest : public testing::Test {
};
TEST_F(MediaInternalsTest, UpdateAddsNewItem) {
- UpdateItem("some.item", "testing", Value::CreateBooleanValue(true));
+ UpdateItem("some.item", "testing", base::TrueValue());
bool testing = false;
std::string id;
@@ -53,9 +53,9 @@ TEST_F(MediaInternalsTest, UpdateAddsNewItem) {
}
TEST_F(MediaInternalsTest, UpdateModifiesExistingItem) {
- UpdateItem("some.item", "testing", Value::CreateBooleanValue(true));
- UpdateItem("some.item", "value", Value::CreateIntegerValue(5));
- UpdateItem("some.item", "testing", Value::CreateBooleanValue(false));
+ UpdateItem("some.item", "testing", base::TrueValue());
+ UpdateItem("some.item", "value", base::NumberValue::New(5));
+ UpdateItem("some.item", "testing", base::FalseValue());
bool testing = true;
int value = 0;
std::string id;
@@ -94,7 +94,7 @@ TEST_F(MediaInternalsTest, RemovedObserversReceiveNoNotifications) {
TEST_F(MediaInternalsTest, DeleteRemovesItem) {
Value* out;
- UpdateItem("some.item", "testing", Value::CreateNullValue());
+ UpdateItem("some.item", "testing", base::NullValue());
EXPECT_TRUE(data()->Get("some.item", &out));
EXPECT_TRUE(data()->Get("some", &out));
« no previous file with comments | « chrome/browser/media/media_internals.cc ('k') | chrome/browser/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698