Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: chrome/browser/ui/webui/options/chromeos/about_page_handler.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/about_page_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/about_page_handler.cc b/chrome/browser/ui/webui/options/chromeos/about_page_handler.cc
index ce12780b9547b466386e42b3708305b7137e54be..952310e7a1070b61acb1aaf339bfb938836d00c2 100644
--- a/chrome/browser/ui/webui/options/chromeos/about_page_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/about_page_handler.cc
@@ -369,19 +369,19 @@ void AboutPageHandler::UpdateStatus(
break;
}
if (message.size()) {
- scoped_ptr<Value> update_message(Value::CreateStringValue(message));
+ scoped_ptr<Value> update_message(base::StringValue::New(message));
// "Checking for update..." needs to be shown for a while, so users
// can read it, hence insert delay for this.
- scoped_ptr<Value> insert_delay(Value::CreateBooleanValue(
+ scoped_ptr<Value> insert_delay(base::BooleanValue::New(
status.status == UPDATE_STATUS_CHECKING_FOR_UPDATE));
web_ui_->CallJavascriptFunction("AboutPage.updateStatusCallback",
*update_message, *insert_delay);
- scoped_ptr<Value> enabled_value(Value::CreateBooleanValue(enabled));
+ scoped_ptr<Value> enabled_value(base::BooleanValue::New(enabled));
web_ui_->CallJavascriptFunction("AboutPage.updateEnableCallback",
*enabled_value);
- scoped_ptr<Value> image_string(Value::CreateStringValue(image));
+ scoped_ptr<Value> image_string(base::StringValue::New(image));
web_ui_->CallJavascriptFunction("AboutPage.setUpdateImage",
*image_string);
}
@@ -394,7 +394,7 @@ void AboutPageHandler::UpdateStatus(
void AboutPageHandler::OnOSVersion(VersionLoader::Handle handle,
std::string version) {
if (version.size()) {
- scoped_ptr<Value> version_string(Value::CreateStringValue(version));
+ scoped_ptr<Value> version_string(base::StringValue::New(version));
web_ui_->CallJavascriptFunction("AboutPage.updateOSVersionCallback",
*version_string);
}
@@ -403,7 +403,7 @@ void AboutPageHandler::OnOSVersion(VersionLoader::Handle handle,
void AboutPageHandler::OnOSFirmware(VersionLoader::Handle handle,
std::string firmware) {
if (firmware.size()) {
- scoped_ptr<Value> firmware_string(Value::CreateStringValue(firmware));
+ scoped_ptr<Value> firmware_string(base::StringValue::New(firmware));
web_ui_->CallJavascriptFunction("AboutPage.updateOSFirmwareCallback",
*firmware_string);
}
@@ -421,7 +421,7 @@ void AboutPageHandler::UpdateSelectedChannel(void* user_data,
if (CrosLibrary::Get()->GetUpdateLibrary()->HasObserver(observer)) {
// If UpdateLibrary still has the observer, then the page handler is valid.
AboutPageHandler* handler = observer->page_handler();
- scoped_ptr<Value> channel_string(Value::CreateStringValue(channel));
+ scoped_ptr<Value> channel_string(base::StringValue::New(channel));
handler->web_ui_->CallJavascriptFunction(
"AboutPage.updateSelectedOptionCallback", *channel_string);
}

Powered by Google App Engine
This is Rietveld 408576698