Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Side by Side Diff: chrome/browser/prefs/session_startup_pref_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/session_startup_pref.h" 5 #include "chrome/browser/prefs/session_startup_pref.h"
6 #include "chrome/common/pref_names.h" 6 #include "chrome/common/pref_names.h"
7 #include "chrome/test/base/testing_pref_service.h" 7 #include "chrome/test/base/testing_pref_service.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 // Unit tests for SessionStartupPref. 11 // Unit tests for SessionStartupPref.
12 class SessionStartupPrefTest : public testing::Test { 12 class SessionStartupPrefTest : public testing::Test {
13 public: 13 public:
14 virtual void SetUp() { 14 virtual void SetUp() {
15 pref_service_.reset(new TestingPrefService); 15 pref_service_.reset(new TestingPrefService);
16 SessionStartupPref::RegisterUserPrefs(pref_service_.get()); 16 SessionStartupPref::RegisterUserPrefs(pref_service_.get());
17 } 17 }
18 18
19 scoped_ptr<TestingPrefService> pref_service_; 19 scoped_ptr<TestingPrefService> pref_service_;
20 }; 20 };
21 21
22 TEST_F(SessionStartupPrefTest, URLListIsFixedUp) { 22 TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
23 ListValue* url_pref_list = new ListValue; 23 ListValue* url_pref_list = new ListValue;
24 url_pref_list->Set(0, Value::CreateStringValue("google.com")); 24 url_pref_list->Set(0, base::StringValue::New("google.com"));
25 url_pref_list->Set(1, Value::CreateStringValue("chromium.org")); 25 url_pref_list->Set(1, base::StringValue::New("chromium.org"));
26 pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list); 26 pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list);
27 27
28 SessionStartupPref result = 28 SessionStartupPref result =
29 SessionStartupPref::GetStartupPref(pref_service_.get()); 29 SessionStartupPref::GetStartupPref(pref_service_.get());
30 EXPECT_EQ(2u, result.urls.size()); 30 EXPECT_EQ(2u, result.urls.size());
31 EXPECT_EQ("http://google.com/", result.urls[0].spec()); 31 EXPECT_EQ("http://google.com/", result.urls[0].spec());
32 EXPECT_EQ("http://chromium.org/", result.urls[1].spec()); 32 EXPECT_EQ("http://chromium.org/", result.urls[1].spec());
33 } 33 }
34 34
35 TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) { 35 TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) {
36 ListValue* url_pref_list1 = new ListValue; 36 ListValue* url_pref_list1 = new ListValue;
37 url_pref_list1->Set(0, Value::CreateStringValue("chromium.org")); 37 url_pref_list1->Set(0, base::StringValue::New("chromium.org"));
38 pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list1); 38 pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup, url_pref_list1);
39 39
40 ListValue* url_pref_list2 = new ListValue; 40 ListValue* url_pref_list2 = new ListValue;
41 url_pref_list2->Set(0, Value::CreateStringValue("chromium.org")); 41 url_pref_list2->Set(0, base::StringValue::New("chromium.org"));
42 url_pref_list2->Set(1, Value::CreateStringValue("chromium.org")); 42 url_pref_list2->Set(1, base::StringValue::New("chromium.org"));
43 url_pref_list2->Set(2, Value::CreateStringValue("chromium.org")); 43 url_pref_list2->Set(2, base::StringValue::New("chromium.org"));
44 pref_service_->SetManagedPref(prefs::kURLsToRestoreOnStartup, 44 pref_service_->SetManagedPref(prefs::kURLsToRestoreOnStartup,
45 url_pref_list2); 45 url_pref_list2);
46 46
47 SessionStartupPref result = 47 SessionStartupPref result =
48 SessionStartupPref::GetStartupPref(pref_service_.get()); 48 SessionStartupPref::GetStartupPref(pref_service_.get());
49 EXPECT_EQ(3u, result.urls.size()); 49 EXPECT_EQ(3u, result.urls.size());
50 50
51 SessionStartupPref override_test = 51 SessionStartupPref override_test =
52 SessionStartupPref(SessionStartupPref::URLS); 52 SessionStartupPref(SessionStartupPref::URLS);
53 override_test.urls.push_back(GURL("dev.chromium.org")); 53 override_test.urls.push_back(GURL("dev.chromium.org"));
54 SessionStartupPref::SetStartupPref(pref_service_.get(), override_test); 54 SessionStartupPref::SetStartupPref(pref_service_.get(), override_test);
55 55
56 result = SessionStartupPref::GetStartupPref(pref_service_.get()); 56 result = SessionStartupPref::GetStartupPref(pref_service_.get());
57 EXPECT_EQ(3u, result.urls.size()); 57 EXPECT_EQ(3u, result.urls.size());
58 } 58 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/session_startup_pref.cc ('k') | chrome/browser/prefs/testing_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698