Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4957)

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc
diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
index e78baa4d0286da4e1d00e64141967a7109e52f69..a931b41e6fdb6755b88fa145f1a948a676f6fcf4 100644
--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc
+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc
@@ -678,7 +678,7 @@ TEST_F(HostContentSettingsMapTest, MigrateObsoletePrefs) {
net::StaticCookiePolicy::BLOCK_ALL_COOKIES);
ListValue popup_hosts;
- popup_hosts.Append(new StringValue("[*.]example.com"));
+ popup_hosts.Append(base::StringValue::New("[*.]example.com"));
prefs->Set(prefs::kPopupWhitelistedHosts, popup_hosts);
HostContentSettingsMap* host_content_settings_map =
@@ -911,7 +911,7 @@ TEST_F(HostContentSettingsMapTest, ManagedDefaultContentSetting) {
// Set managed-default-content-setting through the coresponding preferences.
prefs->SetManagedPref(prefs::kManagedDefaultJavaScriptSetting,
- Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ base::NumberValue::New(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
host_content_settings_map->GetDefaultContentSetting(
CONTENT_SETTINGS_TYPE_JAVASCRIPT));
@@ -924,7 +924,7 @@ TEST_F(HostContentSettingsMapTest, ManagedDefaultContentSetting) {
// Set preference to manage the default-content-setting for Plugins.
prefs->SetManagedPref(prefs::kManagedDefaultPluginsSetting,
- Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ base::NumberValue::New(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
host_content_settings_map->GetDefaultContentSetting(
CONTENT_SETTINGS_TYPE_PLUGINS));
@@ -964,7 +964,7 @@ TEST_F(HostContentSettingsMapTest,
// Set managed-default-content-setting for content-settings-type JavaScript.
prefs->SetManagedPref(prefs::kManagedDefaultJavaScriptSetting,
- Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
+ base::NumberValue::New(CONTENT_SETTING_ALLOW));
EXPECT_EQ(CONTENT_SETTING_ALLOW,
host_content_settings_map->GetContentSetting(
host, host, CONTENT_SETTINGS_TYPE_JAVASCRIPT, ""));
@@ -1004,7 +1004,7 @@ TEST_F(HostContentSettingsMapTest,
// Set managed-default-content-settings-preferences.
prefs->SetManagedPref(prefs::kManagedDefaultJavaScriptSetting,
- Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ base::NumberValue::New(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
host_content_settings_map->GetContentSetting(
host, host, CONTENT_SETTINGS_TYPE_JAVASCRIPT, ""));
@@ -1033,7 +1033,7 @@ TEST_F(HostContentSettingsMapTest, OverwrittenDefaultContentSetting) {
// Set preference to manage the default-content-setting for Cookies.
prefs->SetManagedPref(prefs::kManagedDefaultCookiesSetting,
- Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
+ base::NumberValue::New(CONTENT_SETTING_ALLOW));
EXPECT_EQ(CONTENT_SETTING_ALLOW,
host_content_settings_map->GetDefaultContentSetting(
CONTENT_SETTINGS_TYPE_COOKIES));
@@ -1055,7 +1055,7 @@ TEST_F(HostContentSettingsMapTest, SettingDefaultContentSettingsWhenManaged) {
TestingPrefService* prefs = profile.GetTestingPrefService();
prefs->SetManagedPref(prefs::kManagedDefaultPluginsSetting,
- Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
+ base::NumberValue::New(CONTENT_SETTING_ALLOW));
EXPECT_EQ(CONTENT_SETTING_ALLOW,
host_content_settings_map->GetDefaultContentSetting(
CONTENT_SETTINGS_TYPE_PLUGINS));

Powered by Google App Engine
This is Rietveld 408576698