Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 7649006: more changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix another typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index a949b4df1de9d75d041314d9248999ed25cfe9b4..309638ad8e4cbbbe0387cb9d247b12bc46f71e45 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -590,7 +590,7 @@ bool CreateWindowFunction::RunImpl() {
if (new_window->profile()->IsOffTheRecord() && !include_incognito()) {
// Don't expose incognito windows if the extension isn't allowed.
- result_.reset(Value::CreateNullValue());
+ result_.reset(base::NullValue());
} else {
result_.reset(ExtensionTabUtil::CreateWindowValue(new_window, true));
}
@@ -1307,7 +1307,7 @@ void CaptureVisibleTabFunction::SendResultFromBitmap(
base::Base64Encode(stream_as_string, &base64_result);
base64_result.insert(0, base::StringPrintf("data:%s;base64,",
mime_type.c_str()));
- result_.reset(new StringValue(base64_result));
+ result_.reset(base::StringValue::New(base64_result));
SendResponse(true);
}
@@ -1378,7 +1378,7 @@ void DetectTabLanguageFunction::Observe(int type,
}
void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
- result_.reset(Value::CreateStringValue(language.c_str()));
+ result_.reset(base::StringValue::New(language.c_str()));
SendResponse(true);
Release(); // Balanced in Run()

Powered by Google App Engine
This is Rietveld 408576698