[Content] Update V8ValueConverter::create to return a std::unique_ptr

[Content] Update V8ValueConverter::create to return a std::unique_ptr

Instead of returning a raw pointer with ownership, have
content::V8ValueConverter::Create return a unique_ptr. This is a)
safer, since ownership is clear and safe by default and b) has the
added bonus of making inline calls easier (e.g.,
V8ValueConverter::Create()->ToV8Value()).

Also s/create()/Create() to match Chromium style.

BUG=732437
Review-Url: https://codereview.chromium.org/2931393003
Cr-Commit-Position: refs/heads/master@{#479172}
Committed: https://chromium.googlesource.com/chromium/src/+/694c6057a16e65dca77d04ba04c3cb35440b9f44

[Devlin, 2017-06-12 17:25:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 17:25:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 18:41:26]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-12 20:22:15]

rdevlin.cronin@chromium.org changed reviewers:
+ jochen@chromium.org, lazyboy@chromium.org

[Devlin, 2017-06-12 20:22:16]

jochen@ + lazyboy@, mind taking a look?

lazyboy@ - extensions
jochen@ - everything else :)

+jbroman@ FYI.

https://codereview.chromium.org/2931393003/diff/1/chrome/renderer/extensions/...
File chrome/renderer/extensions/notifications_native_handler.cc (right):

https://codereview.chromium.org/2931393003/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/notifications_native_handler.cc:34: // TODO(devlin):
Prefer gin::DataObjectBuilder here.
(If https://codereview.chromium.org/2937543002/ lands first, I'll update this)

[lazyboy, 2017-06-12 22:26:27]

extensions LGTM

[jochen (gone - plz use gerrit), 2017-06-13 07:22:42]

lgtm

[Devlin, 2017-06-13 20:44:41]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 20:45:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-13 21:54:20]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-13 21:54:24]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-13 21:54:24]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2931393003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-13 21:54:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 22:07:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497390864224110,
"parent_rev": "84d09459319bcf4e71fbfd2cf002602ca2f74d8f", "commit_rev":
"694c6057a16e65dca77d04ba04c3cb35440b9f44"}

[commit-bot: I haz the power, 2017-06-13 22:07:49]

Description was changed from

==========
[Content] Update V8ValueConverter::create to return a std::unique_ptr

Instead of returning a raw pointer with ownership, have
content::V8ValueConverter::Create return a unique_ptr. This is a)
safer, since ownership is clear and safe by default and b) has the
added bonus of making inline calls easier (e.g.,
V8ValueConverter::Create()->ToV8Value()).

Also s/create()/Create() to match Chromium style.

BUG=732437
==========

to

==========
[Content] Update V8ValueConverter::create to return a std::unique_ptr

Instead of returning a raw pointer with ownership, have
content::V8ValueConverter::Create return a unique_ptr. This is a)
safer, since ownership is clear and safe by default and b) has the
added bonus of making inline calls easier (e.g.,
V8ValueConverter::Create()->ToV8Value()).

Also s/create()/Create() to match Chromium style.

BUG=732437

Review-Url: https://codereview.chromium.org/2931393003
Cr-Commit-Position: refs/heads/master@{#479172}
Committed:
https://chromium.googlesource.com/chromium/src/+/694c6057a16e65dca77d04ba04c3...
==========

[commit-bot: I haz the power, 2017-06-13 22:07:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/694c6057a16e65dca77d04ba04c3...