content/child/v8_value_converter_impl.cc - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/v8_value_converter_impl.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/v8_value_converter_impl.cc

diff --git a/content/child/v8_value_converter_impl.cc b/content/child/v8_value_converter_impl.cc

index 89b3fc79c78abffc275a636ba54c14a6a8160d30..a786dc26be049c7a93c855d2fd9304050ae205d5 100644

--- a/content/child/v8_value_converter_impl.cc

+++ b/content/child/v8_value_converter_impl.cc

@@ -175,8 +175,8 @@ class V8ValueConverterImpl::ScopedUniquenessGuard {

DISALLOW_COPY_AND_ASSIGN(ScopedUniquenessGuard);

};

-V8ValueConverter* V8ValueConverter::create() {

- return new V8ValueConverterImpl();

+std::unique_ptr<V8ValueConverter> V8ValueConverter::Create() {

+ return base::MakeUnique<V8ValueConverterImpl>();

}

V8ValueConverterImpl::V8ValueConverterImpl()