Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: extensions/renderer/api_event_listeners.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_event_handler.cc ('k') | extensions/renderer/api_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_event_listeners.cc
diff --git a/extensions/renderer/api_event_listeners.cc b/extensions/renderer/api_event_listeners.cc
index 96945ddfa91c6fca2b50ff276292b0f9383fd2f6..27f2ab39677814f7d4cfe75c8a63fa26aa3bc78c 100644
--- a/extensions/renderer/api_event_listeners.cc
+++ b/extensions/renderer/api_event_listeners.cc
@@ -64,9 +64,8 @@ bool ValidateFilter(v8::Local<v8::Context> context,
return false;
}
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- std::unique_ptr<base::Value> value = converter->FromV8Value(filter, context);
+ std::unique_ptr<base::Value> value =
+ content::V8ValueConverter::Create()->FromV8Value(filter, context);
if (!value || !value->is_dict()) {
*error = "could not convert filter.";
return false;
« no previous file with comments | « extensions/renderer/api_event_handler.cc ('k') | extensions/renderer/api_request_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698