extensions/renderer/dispatcher.cc - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index 75c29b77896cfa2682da3702218387815ef71c31..f22e715f4a37f1d5e86c155b10cf96f88c01a19b 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -149,8 +149,8 @@ void CallModuleMethod(const std::string& module_name,

v8::HandleScope handle_scope(context->isolate());

v8::Context::Scope context_scope(context->v8_context());

- std::unique_ptr<content::V8ValueConverter> converter(

- content::V8ValueConverter::create());

+ std::unique_ptr<content::V8ValueConverter> converter =

+ content::V8ValueConverter::Create();

std::vector<v8::Local<v8::Value>> arguments;

for (const auto& arg : *args) {