Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2762)

Unified Diff: content/renderer/skia_benchmarking_extension.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/java/gin_java_bridge_value_converter.cc ('k') | content/renderer/web_ui_extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/skia_benchmarking_extension.cc
diff --git a/content/renderer/skia_benchmarking_extension.cc b/content/renderer/skia_benchmarking_extension.cc
index b0344520fce7dc3e362b8996dd9bb0355d8d7787..0081051b5ed16332ba00bcc541459e4b294ec389 100644
--- a/content/renderer/skia_benchmarking_extension.cc
+++ b/content/renderer/skia_benchmarking_extension.cc
@@ -76,10 +76,8 @@ class GfxImageDeserializer final : public SkImageDeserializer {
std::unique_ptr<base::Value> ParsePictureArg(v8::Isolate* isolate,
v8::Local<v8::Value> arg) {
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- return std::unique_ptr<base::Value>(
- converter->FromV8Value(arg, isolate->GetCurrentContext()));
+ return content::V8ValueConverter::Create()->FromV8Value(
+ arg, isolate->GetCurrentContext());
}
std::unique_ptr<Picture> CreatePictureFromEncodedString(
@@ -209,10 +207,8 @@ void SkiaBenchmarking::Rasterize(gin::Arguments* args) {
if (!args->PeekNext().IsEmpty()) {
v8::Local<v8::Value> params;
args->GetNext(&params);
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- std::unique_ptr<base::Value> params_value(
- converter->FromV8Value(params, context));
+ std::unique_ptr<base::Value> params_value =
+ content::V8ValueConverter::Create()->FromV8Value(params, context);
const base::DictionaryValue* params_dict = NULL;
if (params_value.get() && params_value->GetAsDictionary(&params_dict)) {
@@ -282,10 +278,9 @@ void SkiaBenchmarking::GetOps(gin::Arguments* args) {
picture->picture->playback(&benchmarking_canvas);
v8::Local<v8::Context> context = isolate->GetCurrentContext();
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- args->Return(converter->ToV8Value(&benchmarking_canvas.Commands(), context));
+ args->Return(content::V8ValueConverter::Create()->ToV8Value(
+ &benchmarking_canvas.Commands(), context));
}
void SkiaBenchmarking::GetOpTimings(gin::Arguments* args) {
« no previous file with comments | « content/renderer/java/gin_java_bridge_value_converter.cc ('k') | content/renderer/web_ui_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698