Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: components/plugins/renderer/loadable_plugin_placeholder.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/sandbox_status_extension_android.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/loadable_plugin_placeholder.cc
diff --git a/components/plugins/renderer/loadable_plugin_placeholder.cc b/components/plugins/renderer/loadable_plugin_placeholder.cc
index 41ff1b0e6dfe358a6824315af5529d6cadf186b5..c5b3b05876df0216448419a7fb0687cac305160b 100644
--- a/components/plugins/renderer/loadable_plugin_placeholder.cc
+++ b/components/plugins/renderer/loadable_plugin_placeholder.cc
@@ -343,13 +343,11 @@ void LoadablePluginPlaceholder::DidFinishIconRepositionForTestingCallback() {
blink::WebElement element = plugin()->Container()->GetElement();
element.SetAttribute("placeholderReady", "true");
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
base::Value value("placeholderReady");
blink::WebSerializedScriptValue message_data =
blink::WebSerializedScriptValue::Serialize(
blink::MainThreadIsolate(),
- converter->ToV8Value(
+ content::V8ValueConverter::Create()->ToV8Value(
&value,
element.GetDocument().GetFrame()->MainWorldScriptContext()));
blink::WebDOMMessageEvent msg_event(message_data);
« no previous file with comments | « chrome/renderer/sandbox_status_extension_android.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698