Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: extensions/renderer/display_source_custom_bindings.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/dom_activity_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/display_source_custom_bindings.cc
diff --git a/extensions/renderer/display_source_custom_bindings.cc b/extensions/renderer/display_source_custom_bindings.cc
index 37c8bcb9e6b88f0d5d0b7affc26cb08c605b4dbf..0214e53691c3517d2a7ab573353088c6d7df703b 100644
--- a/extensions/renderer/display_source_custom_bindings.cc
+++ b/extensions/renderer/display_source_custom_bindings.cc
@@ -17,8 +17,6 @@
namespace extensions {
-using content::V8ValueConverter;
-
namespace {
const char kErrorNotSupported[] = "Not supported";
const char kInvalidStreamArgs[] = "Invalid stream arguments";
@@ -136,9 +134,9 @@ void DisplaySourceCustomBindings::StartSession(
GetChildValue(start_info, "authenticationInfo", isolate);
if (!auth_info_v8_val->IsNull()) {
CHECK(auth_info_v8_val->IsObject());
- std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
- std::unique_ptr<base::Value> auth_info_val(
- converter->FromV8Value(auth_info_v8_val, context()->v8_context()));
+ std::unique_ptr<base::Value> auth_info_val =
+ content::V8ValueConverter::Create()->FromV8Value(
+ auth_info_v8_val, context()->v8_context());
CHECK(auth_info_val);
auth_info = DisplaySourceAuthInfo::FromValue(*auth_info_val);
}
« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/dom_activity_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698