content/renderer/java/gin_java_bridge_value_converter.cc - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/java/gin_java_bridge_value_converter.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/java/gin_java_bridge_value_converter.cc

diff --git a/content/renderer/java/gin_java_bridge_value_converter.cc b/content/renderer/java/gin_java_bridge_value_converter.cc

index c22cbf3c696056a20e21b407974328dc423e97b2..8a6230db97c07ed8f7175ce70d8dfda9fc9c3f9d 100644

--- a/content/renderer/java/gin_java_bridge_value_converter.cc

+++ b/content/renderer/java/gin_java_bridge_value_converter.cc

@@ -19,7 +19,7 @@

namespace content {

GinJavaBridgeValueConverter::GinJavaBridgeValueConverter()

- : converter_(V8ValueConverter::create()) {

+ : converter_(V8ValueConverter::Create()) {

converter_->SetDateAllowed(false);

converter_->SetRegExpAllowed(false);

converter_->SetFunctionAllowed(true);