Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5030)

Unified Diff: chrome/renderer/sandbox_status_extension_android.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/sandbox_status_extension_android.cc
diff --git a/chrome/renderer/sandbox_status_extension_android.cc b/chrome/renderer/sandbox_status_extension_android.cc
index fe3f8342ca09276397547a1795acff4ca8314019..3b14bf38cb48a859c78c218241c056dc0eb33c0c 100644
--- a/chrome/renderer/sandbox_status_extension_android.cc
+++ b/chrome/renderer/sandbox_status_extension_android.cc
@@ -148,10 +148,8 @@ void SandboxStatusExtension::RunCallback(
v8::Local<v8::Function> callback_local =
v8::Local<v8::Function>::New(isolate, *callback);
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
-
- v8::Local<v8::Value> argv[] = {converter->ToV8Value(status.get(), context)};
+ v8::Local<v8::Value> argv[] = {
+ content::V8ValueConverter::Create()->ToV8Value(status.get(), context)};
render_frame()->GetWebFrame()->CallFunctionEvenIfScriptDisabled(
callback_local, v8::Object::New(isolate), 1, argv);
}
« no previous file with comments | « chrome/renderer/extensions/platform_keys_natives.cc ('k') | components/plugins/renderer/loadable_plugin_placeholder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698