Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3890)

Unified Diff: extensions/renderer/web_request_hooks.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/test_features_native_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/web_request_hooks.cc
diff --git a/extensions/renderer/web_request_hooks.cc b/extensions/renderer/web_request_hooks.cc
index ad2c3fbbd4f9da6b3e7652a131cc78872d485d98..0f833278e2d5860c8baa09d432bc8902a2bd4688 100644
--- a/extensions/renderer/web_request_hooks.cc
+++ b/extensions/renderer/web_request_hooks.cc
@@ -59,10 +59,8 @@ bool WebRequestHooks::CreateCustomEvent(
DCHECK(event_spec);
const base::ListValue* extra_params = nullptr;
CHECK(event_spec->GetList("extraParameters", &extra_params));
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
v8::Local<v8::Value> extra_parameters_spec =
- converter->ToV8Value(extra_params, context);
+ content::V8ValueConverter::Create()->ToV8Value(extra_params, context);
v8::Local<v8::Function> get_event = get_event_value.As<v8::Function>();
v8::Local<v8::Value> args[] = {
« no previous file with comments | « extensions/renderer/test_features_native_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698