content/public/child/v8_value_converter.h - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/child/v8_value_converter.h

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/child/v8_value_converter.h

diff --git a/content/public/child/v8_value_converter.h b/content/public/child/v8_value_converter.h

index f53c7c651d465581874e25ae2c0cce0975dd1c25..56305492c63a6313151f87c00e888f610f45c2f7 100644

--- a/content/public/child/v8_value_converter.h

+++ b/content/public/child/v8_value_converter.h

@@ -72,7 +72,7 @@ class CONTENT_EXPORT V8ValueConverter {

virtual bool FromV8Undefined(std::unique_ptr<base::Value>* out) const;

};

- static V8ValueConverter* create();

+ static std::unique_ptr<V8ValueConverter> Create();

virtual ~V8ValueConverter() {}