Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: extensions/renderer/api_binding_test_util.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_activity_logger.cc ('k') | extensions/renderer/api_event_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_test_util.cc
diff --git a/extensions/renderer/api_binding_test_util.cc b/extensions/renderer/api_binding_test_util.cc
index 262ae6a7cd28a58eb0e7cfebf92689dcbb72266b..99775567241836e4a9131ea401564d095fc2aaaf 100644
--- a/extensions/renderer/api_binding_test_util.cc
+++ b/extensions/renderer/api_binding_test_util.cc
@@ -110,9 +110,7 @@ v8::Local<v8::Function> FunctionFromString(v8::Local<v8::Context> context,
std::unique_ptr<base::Value> V8ToBaseValue(v8::Local<v8::Value> value,
v8::Local<v8::Context> context) {
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- return converter->FromV8Value(value, context);
+ return content::V8ValueConverter::Create()->FromV8Value(value, context);
}
v8::Local<v8::Value> RunFunction(v8::Local<v8::Function> function,
« no previous file with comments | « extensions/renderer/api_activity_logger.cc ('k') | extensions/renderer/api_event_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698