Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: extensions/renderer/activity_log_converter_strategy_unittest.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/web_ui_extension.cc ('k') | extensions/renderer/api_activity_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/activity_log_converter_strategy_unittest.cc
diff --git a/extensions/renderer/activity_log_converter_strategy_unittest.cc b/extensions/renderer/activity_log_converter_strategy_unittest.cc
index 5d82de949aaf46eb82eb48031b7b8604d6656eb1..79059af9a68d95408bc6252c1e8a43daf03956bf 100644
--- a/extensions/renderer/activity_log_converter_strategy_unittest.cc
+++ b/extensions/renderer/activity_log_converter_strategy_unittest.cc
@@ -10,8 +10,6 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
-using content::V8ValueConverter;
-
namespace extensions {
class ActivityLogConverterStrategyTest : public testing::Test {
@@ -24,7 +22,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
protected:
void SetUp() override {
- converter_.reset(V8ValueConverter::create());
+ converter_ = content::V8ValueConverter::Create();
strategy_.reset(new ActivityLogConverterStrategy());
converter_->SetFunctionAllowed(true);
converter_->SetStrategy(strategy_.get());
@@ -94,7 +92,7 @@ class ActivityLogConverterStrategyTest : public testing::Test {
v8::HandleScope handle_scope_;
v8::Global<v8::Context> context_;
v8::Context::Scope context_scope_;
- std::unique_ptr<V8ValueConverter> converter_;
+ std::unique_ptr<content::V8ValueConverter> converter_;
std::unique_ptr<ActivityLogConverterStrategy> strategy_;
};
« no previous file with comments | « content/renderer/web_ui_extension.cc ('k') | extensions/renderer/api_activity_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698