chrome/renderer/extensions/platform_keys_natives.cc - Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/platform_keys_natives.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/platform_keys_natives.cc

diff --git a/chrome/renderer/extensions/platform_keys_natives.cc b/chrome/renderer/extensions/platform_keys_natives.cc

index c0da6678c5ea80ad9d39a7dcadf598ca2ea3d3b8..97ff814c49a86a7cd68d46c3a6e520be56d78c45 100644

--- a/chrome/renderer/extensions/platform_keys_natives.cc

+++ b/chrome/renderer/extensions/platform_keys_natives.cc

@@ -125,10 +125,8 @@ void PlatformKeysNatives::NormalizeAlgorithm(

if (!algorithm_dict)

return;

- std::unique_ptr<content::V8ValueConverter> converter(

- content::V8ValueConverter::create());

- call_info.GetReturnValue().Set(

- converter->ToV8Value(algorithm_dict.get(), context()->v8_context()));

+ call_info.GetReturnValue().Set(content::V8ValueConverter::Create()->ToV8Value(

+ algorithm_dict.get(), context()->v8_context()));

}

} // namespace extensions