Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: extensions/renderer/i18n_custom_bindings.cc

Issue 2931393003: [Content] Update V8ValueConverter::create to return a std::unique_ptr (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/i18n_custom_bindings.cc
diff --git a/extensions/renderer/i18n_custom_bindings.cc b/extensions/renderer/i18n_custom_bindings.cc
index 57e0e96e2e8bfb4f1037fc3a2523056540731e56..828a437628f7e4901d82dc5f9102e6eb971767af 100644
--- a/extensions/renderer/i18n_custom_bindings.cc
+++ b/extensions/renderer/i18n_custom_bindings.cc
@@ -104,9 +104,8 @@ v8::Local<v8::Value> LanguageDetectionResult::ToValue(ScriptContext* context) {
v8::Isolate* isolate = v8_context->GetIsolate();
v8::EscapableHandleScope handle_scope(isolate);
- std::unique_ptr<content::V8ValueConverter> converter(
- content::V8ValueConverter::create());
- v8::Local<v8::Value> result = converter->ToV8Value(&dict_value, v8_context);
+ v8::Local<v8::Value> result =
+ content::V8ValueConverter::Create()->ToV8Value(&dict_value, v8_context);
return handle_scope.Escape(result);
}

Powered by Google App Engine
This is Rietveld 408576698